Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release v1.15.0 #556

Merged
merged 26 commits into from
Sep 13, 2016
Merged

release v1.15.0 #556

merged 26 commits into from
Sep 13, 2016

Conversation

benmosher
Copy link
Member

@benmosher benmosher commented Sep 12, 2016 •
edited
Loading

Should've really just done this last week 😳

  • once-over from @jfmengels
  • tag
  • publish
  • merge package.json back to master

jfmengels and others added 25 commits August 23, 2016 05:32
@jfmengels @benmosher
Add allow option to no-nodejs-modules rule (fixes #452) (#509)
387d333 
* Add `allow` option to `no-nodejs-modules` rule (fixes #452)

* Add test case

* Fix not working in Node v4
@greenkeeperio-bot @benmosher
chore(package): update doctrine to version 1.3.0 (#511)
ff0ef90 
https://greenkeeper.io/
@jquense @benmosher
Fix false positive with default import having a "default" property (f…
0d98253 
…ixes #507, closes #508)
@benmosher
added #508 link to changelog
18c4831
@benmosher
cleanup after #511
9405444
@Gabri3l @benmosher
doc: minor typos (#523)
8da6a5a
@knpwrs
Allow regular expressions for rule no-extraneous-dependencies.
d9b9730
@knpwrs
Add RegExp documentation for no-extraneous-dependencies.
c739798
@knpwrs
Update doc due to review.
1be4720
@knpwrs
Extend no-extraneous-dependencies to support globs and arrays.
8ff322d
@knpwrs
Remove regular expression support from no-extraneous-dependencies.
8d16c08
@benmosher
Suggested change to readme (#535)
2183977 
Took a while to hunt down why my config wasn't working and figured out that I needed to add this dependency only after reading through [#238](#238) and noticing [this line in a linked example](https://gist.github.com/ravasthi/abcfee465411fc45a8bc28decb9d8e5e#file-package-json-L24). I think adding this line may add some clarity and save time for several other webpack / eslint noobs (like me).
@greenkeeperio-bot @benmosher
chore(package): update typescript-eslint-parser to version 0.2.0 (#534)
28dbed8 
https://greenkeeper.io/
@knpwrs
Only support arrays of globs.
505aea8
@knpwrs
Update comments for no-extraneous-dependencies configuration.
2b9b500
@tizmagik
Add test
f6aa376
@tizmagik
Add rule with docs
5eafd09
@tizmagik
Add to src index and main README
90ff3b8
@tizmagik
Update changelog
27c7675
@tizmagik
a code smell
159034c
@jfmengels @benmosher
Add no-absolute-path rule (fixes #530) (#538)
79f3f83 
* Add `no-absolute-path` rule (fixes #530)

* fix typo
@benmosher
Merge remote-tracking branch 'tizmagik/feature/max-dependencies' (#489)
61b1765 
# Conflicts:
#	CHANGELOG.md
@benmosher
Merge branch 'knpwrs/no-extraneous-dependencies-regex' (#527)
b6c1a33
@greenkeeperio-bot @benmosher
chore(package): update babel-plugin-istanbul to version 2.0.1 (#539)
bd99bdf 
https://greenkeeper.io/
@benmosher
v1.15.0
eb1a060
@benmosher benmosher added this to the 1.15.0 milestone Sep 12, 2016
@coveralls
Copy link

coveralls commented Sep 12, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 97.794% when pulling eb1a060 on v1.15.0 into 7995581 on release.

jfmengels
jfmengels reviewed Sep 12, 2016
View reviewed changes
CHANGELOG.md
[`no-absolute-path`]: ./docs/rules/no-absolute-path.md
=======
[`max-dependencies`]: ./docs/rules/max-dependencies.md
>>>>>>> tizmagik/feature/max-dependencies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahah! My publish reviews are finally useful: There's are traces of merge conflicts here 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 I need a pre-commit hook for this. if even just for the changelog.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there should be pre-commit hooks that warn when there are strings like <<<<<<< anywhere in your project. Maybe an idea for https://github.com/SamVerschueren/clinton @SamVerschueren?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good suggestion @jfmengels! Will add it.

@jfmengels
Copy link
Collaborator

LGTM :)

I'm fine with releasing as is, but we're so close to merging #485 that it would be a shame not to include it right away. We could merge it and fix that last comment ourselves. What do you think?

@benmosher
Copy link
Member Author

I'm cool with that, wasn't sure how fast it'd move today and I wanted to get the rest out the door.

If you can merge it into master and rebase this branch back onto the new master, I'm up for it? or I can knock it out in the morning tomorrow probably

@benmosher
Copy link
Member Author

benmosher commented Sep 12, 2016 •
edited
Loading

Plus #555 needs review + will probably merge soon, so v1.16 is probably days away anyway. so I'm cool either way

@jfmengels
Copy link
Collaborator

I'd like to concentrate on writing a blog post (my first one :o) tonight, so I'll leave that to you if you don't mind (plus, I'm not sure I got the whole master/new master branch thing 😅).
And ok, if #555 gets merged in a few days, I'm fine with postponing #485 too.

@benmosher
Copy link
Member Author

sweet deal, no worries. I'll probably punt on #485 until v1.16, and then release that with #555. will need to wait until tomorrow either way.

some part of me still wants releases to be substantial, even though I'm on the CI/CD train. old habits, I guess. 😄

blog post sounds way more important/exciting, get after it! 😎

@coveralls
Copy link

coveralls commented Sep 12, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 97.794% when pulling d03577c on v1.15.0 into 7995581 on release.

@benmosher benmosher merged commit d03577c into release Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
9 participants
@benmosher @coveralls @jfmengels @SamVerschueren @greenkeeperio-bot @jquense @Gabri3l @knpwrs @tizmagik