Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #519: Add option newlines-between: "ignore" to order #584

Merged
merged 2 commits into from
Sep 26, 2016

Conversation

jfmengels
Copy link
Collaborator

Fix #519: Add option newlines-between: "ignore" to order

I haven't yet changed the default option, which I think we should, as I have not yet see any comments from others. That can be done in a second time, but should it be done, it should be done before the v2 release

@coveralls
Copy link

coveralls commented Sep 24, 2016

Coverage Status

Coverage remained the same at 97.815% when pulling 2f5aaf2 on order-newline into e3c41ca on master.

@coveralls
Copy link

coveralls commented Sep 24, 2016

Coverage Status

Coverage remained the same at 97.815% when pulling 2acc1c6 on order-newline into e3c41ca on master.

@jfmengels jfmengels added this to the 2.0.0 milestone Sep 25, 2016
@jfmengels
Copy link
Collaborator Author

I'm putting this in the v2 milestone. At least to not forget evaluating whether to include the breaking change or not.

@benmosher
Copy link
Member

ignore as default makes sense to me. Do you want to add that to this PR?

@benmosher
Copy link
Member

sweet, once that's in I'll publish 2.0.0-beta.0?

@jfmengels
Copy link
Collaborator Author

jfmengels commented Sep 26, 2016

Updated. Yeah, beta v2 sounds good :)

@coveralls
Copy link

coveralls commented Sep 26, 2016

Coverage Status

Coverage increased (+0.002%) to 97.63% when pulling e04819a on order-newline into bd35156 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants