-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting for specifying internal module directories #914
Conversation
Any movement on this? Would love to have this feature so we can properly order the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should this setting interact with https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-internal-modules.md and other rules?
Please add tests for any impacted rules, ideally both a valid and an invalid one.
I don't have time to work on this in the next few months. @jjshammas Feel free to pick it up and make the necessary changes. |
@jjshammas please don’t make a duplicate PR; either post a link here to your branch and i can pull in the commits, or, @Whoaa512 can add you as a collaborator on their fork, and you can make changes directly there. |
@ljharb Did you have any thought or preference on how you think it should handle |
@stramel I'm not sure - it's probably a lot of complexity, and I think that the research needs to be done before making a change here. |
Matching using folder name New setting needs to be documented in the readme, and linked to from the "related" section of the order rule's docs page, as has been done with the |
@stramel Did you gain any insights into how to handle |
fyi: this implementation does not work, when configuring internal-module-folders with something like |
closing on account of staleness + I would rather not add global settings just for this, would prefer the suggestion in this comment |
Closes #807