Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #666: resolve config from source file #993

Closed
wants to merge 2 commits into from
Closed

Fix #666: resolve config from source file #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b10ed1
Fix #666: resolve config from source file
Billy- Jan 5, 2018
5abd41a
Update changelog
Billy- Jan 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
## [Unreleased]

- Add [`group-exports`] rule: style-guide rule to report use of multiple named exports ([#721], thanks [@robertrossmann])
- Fix [#666], webpack resolver incorrectly resolving relative paths to the webpack config ([#993])

## [2.8.0] - 2017-10-18
### Added
Expand Down Expand Up @@ -438,6 +439,7 @@ for info on changes for earlier releases.

[`memo-parser`]: ./memo-parser/README.md

[#993]: https://github.com/benmosher/eslint-plugin-import/pull/993
[#944]: https://github.com/benmosher/eslint-plugin-import/pull/944
[#891]: https://github.com/benmosher/eslint-plugin-import/pull/891
[#858]: https://github.com/benmosher/eslint-plugin-import/pull/858
Expand Down Expand Up @@ -514,6 +516,7 @@ for info on changes for earlier releases.
[#720]: https://github.com/benmosher/eslint-plugin-import/issues/720
[#686]: https://github.com/benmosher/eslint-plugin-import/issues/686
[#671]: https://github.com/benmosher/eslint-plugin-import/issues/671
[#666]: https://github.com/benmosher/eslint-plugin-import/issues/666
[#660]: https://github.com/benmosher/eslint-plugin-import/issues/660
[#653]: https://github.com/benmosher/eslint-plugin-import/issues/653
[#627]: https://github.com/benmosher/eslint-plugin-import/issues/627
Expand Down
2 changes: 1 addition & 1 deletion resolvers/webpack/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ exports.resolve = function (source, file, settings) {
// see if we've got an absolute path
if (!configPath || !isAbsolute(configPath)) {
// if not, find ancestral package.json and use its directory as base for the path
packageDir = findRoot(path.resolve(file))
packageDir = findRoot(path.resolve(source))
if (!packageDir) throw new Error('package not found above ' + file)
}

Expand Down