Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI commands and related logic is now moved to the GiveWP core #19

Merged
merged 13 commits into from
Dec 17, 2020

Conversation

alaca
Copy link
Member

@alaca alaca commented Dec 15, 2020

Blocked by: impress-org/givewp#5512

Resolves #18

Description

This PR moves the CLI commands and related logic to the GiveWP core. The only purpose of this add-on now is to provide an Admin UI to help non-devs to generate the test data.

Affects

This PR affects the add-on structure and most of the logic is moved to the GiveWP core.

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @since tags included in DocBlocks
  • Changes logged to the Unreleased section of CHANGELOG.md
  • Self Review of code and UX completed

Testing Instructions

In order to test this PR, impress-org/givewp#5512 has to be merged into GiveWP core

@alaca alaca requested a review from kjohnson December 15, 2020 18:35
@alaca alaca merged commit 3f0aeff into develop Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestData CLI commands should be integrated into the GiveWP core
2 participants