fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466

samsmith89 · 2018-07-12T21:01:38Z

User Story

As a Site Admin, I want to remove the name title prefixes because I don't like them anymore.

Current Behavior

I currently try to remove them with the "x" provided and when I save the form they don't go away in either the backend or the front-end

Expected Behavior

I expect to use the "x" to remove them.

Steps to Reproduce

Turn on name title prefixes and save the form
Try to remove them and they remove
Update the form and they come back
view the front end and they are still there

Visuals

Screencast of the issue
https://screencast-o-matic.com/watch/cFilY8FAdY

Environment

WordPress System Info

### WordPress Environment ###

Home URL: http://betagive.local
Site URL: http://betagive.local
WP Version: 4.9.7
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, refunded, failed, revoked, cancelled, abandoned, processing, preapproval, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: betagive.local
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache/2.4.10 (Debian)
PHP Version: 7.0.3
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: 5.6.34
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.2.0
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access✔Daily Email Report✔Weekly Email Report✔Monthly Email Report❌Renewal Receipt Email❌Subscription Cancelled Email❌Subscription Completed Email❌Subscription Reminder Email✔Subscriptions Email Access
Upgraded From: 2.2.0
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://betagive.local/donation-confirmation/
Failure Page: http://betagive.local/donation-failed/
Donation History Page: http://betagive.local/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, PayPal Standard, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled

Active Give Add-ons

Give - Currency Switcher: ❌ Unlicensed – by WordImpress – 1.2.1

Other Active Plugins

Email Cop: by Ashfame – 0.1.1
Give - Authorize.net Gateway: by WordImpress – 1.4.2
Give - Email Reports: by WordImpress – 1.1.2
Give - Google Analytics Donation Tracking: by WordImpress – 1.1.4
Give - Hook Helper: by Ravinder Kumar – 1.0
Give - MailChimp: by WordImpress – 1.4.1
Give - Manual Donations: by WordImpress – 1.4.1
Give - PayPal Pro Gateway: by WordImpress – 1.1.6
Give - PDF Receipts: by WordImpress – 2.3
Give - Per Form Gateways: by WordImpress – 1.0.1
Give - Recurring Donations: by WordImpress – 1.7.1
Give - Stripe Gateway: by WordImpress – 2.0.7
Give - Tributes: by WordImpress – 1.4.2
Give - Zapier: by WordImpress – 1.2.1

Inactive Plugins

Give - Fee Recovery: by WordImpress – 1.7.0
Give - Form Field Manager: by WordImpress – 1.4
Give - Gift Aid: by WordImpress – 1.1.4

Active MU Plugins

Bypass Login: by Stephen Carnam – 1.1.0
Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0

Theme

Name: Twenty Seventeen
Version: 1.6
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

Operating System

Platform: Mac OS X

Browser

Name: Chrome

ravinderk · 2018-07-13T11:21:27Z

@mehul0810 I got PHP notice when save empty value into global setting. Please take a look.

[13-Jul-2018 10:27:20 UTC] PHP Warning:  Invalid argument supplied for foreach() in /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php on line 828
[13-Jul-2018 10:27:20 UTC] PHP Stack trace:
[13-Jul-2018 10:27:20 UTC] PHP   1. {main}() /app/public/wp-admin/edit.php:0
[13-Jul-2018 10:27:20 UTC] PHP   2. require_once() /app/public/wp-admin/edit.php:10
[13-Jul-2018 10:27:20 UTC] PHP   3. do_action() /app/public/wp-admin/admin.php:224
[13-Jul-2018 10:27:21 UTC] PHP   4. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453
[13-Jul-2018 10:27:21 UTC] PHP   5. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310
[13-Jul-2018 10:27:21 UTC] PHP   6. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286
[13-Jul-2018 10:27:21 UTC] PHP   7. Give_Admin_Settings->output() /app/public/wp-includes/class-wp-hook.php:286
[13-Jul-2018 10:27:21 UTC] PHP   8. include() /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php:263
[13-Jul-2018 10:27:21 UTC] PHP   9. do_action() /app/public/wp-content/plugins/Give/includes/admin/views/html-admin-settings.php:109
[13-Jul-2018 10:27:21 UTC] PHP  10. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453
[13-Jul-2018 10:27:21 UTC] PHP  11. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310
[13-Jul-2018 10:27:21 UTC] PHP  12. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286
[13-Jul-2018 10:27:21 UTC] PHP  13. Give_Settings_Page->output() /app/public/wp-includes/class-wp-hook.php:286
[13-Jul-2018 10:27:21 UTC] PHP  14. Give_Admin_Settings::output_fields() /app/public/wp-content/plugins/Give/includes/admin/abstract-admin-settings-page.php:230

ravinderk · 2018-07-13T11:31:16Z

@mehul0810 I am seeing double quotes in attribute, please check:

raftaar1191 · 2018-07-16T04:17:32Z

Finding

Getting PHP notices in Donation Form Page too
Video Link: https://screencast-o-matic.com/watch/cFiDfDFkGA

raftaar1191 · 2018-07-16T04:34:50Z

Debug Log

[16-Jul-2018 04:33:47 UTC] PHP Warning: array_combine() [function.array-combine]: Both parameters should have at least 1 element in /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php on line 813 [16-Jul-2018 04:33:47 UTC] PHP Stack trace: [16-Jul-2018 04:33:47 UTC] PHP 1. {main}() /app/public/wp-admin/edit.php:0 [16-Jul-2018 04:33:47 UTC] PHP 2. require_once() /app/public/wp-admin/edit.php:10 [16-Jul-2018 04:33:47 UTC] PHP 3. do_action() /app/public/wp-admin/admin.php:224 [16-Jul-2018 04:33:47 UTC] PHP 4. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453 [16-Jul-2018 04:33:47 UTC] PHP 5. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310 [16-Jul-2018 04:33:47 UTC] PHP 6. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 7. Give_Admin_Settings->output() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 8. include() /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php:263 [16-Jul-2018 04:33:47 UTC] PHP 9. do_action() /app/public/wp-content/plugins/Give/includes/admin/views/html-admin-settings.php:109 [16-Jul-2018 04:33:47 UTC] PHP 10. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453 [16-Jul-2018 04:33:47 UTC] PHP 11. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310 [16-Jul-2018 04:33:47 UTC] PHP 12. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 13. Give_Settings_Page->output() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 14. Give_Admin_Settings::output_fields() /app/public/wp-content/plugins/Give/includes/admin/abstract-admin-settings-page.php:230 [16-Jul-2018 04:33:47 UTC] PHP 15. array_combine() /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php:813 [16-Jul-2018 04:33:47 UTC] PHP Warning: array_merge() [function.array-merge]: Argument #2 is not an array in /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php on line 813 [16-Jul-2018 04:33:47 UTC] PHP Stack trace: [16-Jul-2018 04:33:47 UTC] PHP 1. {main}() /app/public/wp-admin/edit.php:0 [16-Jul-2018 04:33:47 UTC] PHP 2. require_once() /app/public/wp-admin/edit.php:10 [16-Jul-2018 04:33:47 UTC] PHP 3. do_action() /app/public/wp-admin/admin.php:224 [16-Jul-2018 04:33:47 UTC] PHP 4. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453 [16-Jul-2018 04:33:47 UTC] PHP 5. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310 [16-Jul-2018 04:33:47 UTC] PHP 6. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 7. Give_Admin_Settings->output() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 8. include() /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php:263 [16-Jul-2018 04:33:47 UTC] PHP 9. do_action() /app/public/wp-content/plugins/Give/includes/admin/views/html-admin-settings.php:109 [16-Jul-2018 04:33:47 UTC] PHP 10. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453 [16-Jul-2018 04:33:47 UTC] PHP 11. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310 [16-Jul-2018 04:33:47 UTC] PHP 12. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 13. Give_Settings_Page->output() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 14. Give_Admin_Settings::output_fields() /app/public/wp-content/plugins/Give/includes/admin/abstract-admin-settings-page.php:230 [16-Jul-2018 04:33:47 UTC] PHP 15. array_merge() /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php:813 [16-Jul-2018 04:33:47 UTC] PHP Warning: Invalid argument supplied for foreach() in /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php on line 828 [16-Jul-2018 04:33:47 UTC] PHP Stack trace: [16-Jul-2018 04:33:47 UTC] PHP 1. {main}() /app/public/wp-admin/edit.php:0 [16-Jul-2018 04:33:47 UTC] PHP 2. require_once() /app/public/wp-admin/edit.php:10 [16-Jul-2018 04:33:47 UTC] PHP 3. do_action() /app/public/wp-admin/admin.php:224 [16-Jul-2018 04:33:47 UTC] PHP 4. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453 [16-Jul-2018 04:33:47 UTC] PHP 5. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310 [16-Jul-2018 04:33:47 UTC] PHP 6. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 7. Give_Admin_Settings->output() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 8. include() /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php:263 [16-Jul-2018 04:33:47 UTC] PHP 9. do_action() /app/public/wp-content/plugins/Give/includes/admin/views/html-admin-settings.php:109 [16-Jul-2018 04:33:47 UTC] PHP 10. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453 [16-Jul-2018 04:33:47 UTC] PHP 11. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310 [16-Jul-2018 04:33:47 UTC] PHP 12. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 13. Give_Settings_Page->output() /app/public/wp-includes/class-wp-hook.php:286 [16-Jul-2018 04:33:47 UTC] PHP 14. Give_Admin_Settings::output_fields() /app/public/wp-content/plugins/Give/includes/admin/abstract-admin-settings-page.php:230

raftaar1191 · 2018-07-16T04:46:15Z

Slack Call Summary

Participants: @mehul0810 @raftaar1191
Topic: Regenerating the Issues
Result: These issues exist in PHP version 5.3 only

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466

ravinderk · 2018-07-16T05:33:40Z

@Mehul I am not able to save custom title prefix from form metabox

ravinderk · 2018-07-16T05:37:15Z

@mehul0810

debug.log

[16-Jul-2018 05:35:49 UTC] PHP Warning:  array_filter() expects parameter 1 to be array, string given in /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php on line 323
[16-Jul-2018 05:35:49 UTC] PHP Stack trace:
[16-Jul-2018 05:35:49 UTC] PHP   1. {main}() /app/public/wp-admin/post.php:0
[16-Jul-2018 05:35:49 UTC] PHP   2. include() /app/public/wp-admin/post.php:174
[16-Jul-2018 05:35:49 UTC] PHP   3. do_meta_boxes() /app/public/wp-admin/edit-form-advanced.php:714
[16-Jul-2018 05:35:49 UTC] PHP   4. call_user_func:{/app/public/wp-admin/includes/template.php:1063}() /app/public/wp-admin/includes/template.php:1063
[16-Jul-2018 05:35:49 UTC] PHP   5. Give_MetaBox_Form_Data->output() /app/public/wp-admin/includes/template.php:1063
[16-Jul-2018 05:35:49 UTC] PHP   6. give_render_field() /app/public/wp-content/plugins/Give/includes/admin/forms/class-metabox-form-data.php:795
[16-Jul-2018 05:35:49 UTC] PHP   7. give_chosen_input() /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php:214
[16-Jul-2018 05:35:49 UTC] PHP   8. array_filter() /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php:323
[16-Jul-2018 05:35:49 UTC] PHP Warning:  array_fill_keys() expects parameter 1 to be array, null given in /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php on line 324
[16-Jul-2018 05:35:49 UTC] PHP Stack trace:
[16-Jul-2018 05:35:49 UTC] PHP   1. {main}() /app/public/wp-admin/post.php:0
[16-Jul-2018 05:35:49 UTC] PHP   2. include() /app/public/wp-admin/post.php:174
[16-Jul-2018 05:35:49 UTC] PHP   3. do_meta_boxes() /app/public/wp-admin/edit-form-advanced.php:714
[16-Jul-2018 05:35:49 UTC] PHP   4. call_user_func:{/app/public/wp-admin/includes/template.php:1063}() /app/public/wp-admin/includes/template.php:1063
[16-Jul-2018 05:35:49 UTC] PHP   5. Give_MetaBox_Form_Data->output() /app/public/wp-admin/includes/template.php:1063
[16-Jul-2018 05:35:49 UTC] PHP   6. give_render_field() /app/public/wp-content/plugins/Give/includes/admin/forms/class-metabox-form-data.php:795
[16-Jul-2018 05:35:49 UTC] PHP   7. give_chosen_input() /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php:214
[16-Jul-2018 05:35:49 UTC] PHP   8. array_fill_keys() /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php:324
[16-Jul-2018 05:36:02 UTC] PHP Warning:  array_filter() expects parameter 1 to be array, string given in /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php on line 323
[16-Jul-2018 05:36:02 UTC] PHP Stack trace:
[16-Jul-2018 05:36:02 UTC] PHP   1. {main}() /app/public/wp-admin/post.php:0
[16-Jul-2018 05:36:02 UTC] PHP   2. include() /app/public/wp-admin/post.php:174
[16-Jul-2018 05:36:02 UTC] PHP   3. do_meta_boxes() /app/public/wp-admin/edit-form-advanced.php:714
[16-Jul-2018 05:36:02 UTC] PHP   4. call_user_func:{/app/public/wp-admin/includes/template.php:1063}() /app/public/wp-admin/includes/template.php:1063
[16-Jul-2018 05:36:02 UTC] PHP   5. Give_MetaBox_Form_Data->output() /app/public/wp-admin/includes/template.php:1063
[16-Jul-2018 05:36:02 UTC] PHP   6. give_render_field() /app/public/wp-content/plugins/Give/includes/admin/forms/class-metabox-form-data.php:795
[16-Jul-2018 05:36:02 UTC] PHP   7. give_chosen_input() /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php:214
[16-Jul-2018 05:36:02 UTC] PHP   8. array_filter() /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php:323
[16-Jul-2018 05:36:02 UTC] PHP Warning:  array_fill_keys() expects parameter 1 to be array, null given in /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php on line 324
[16-Jul-2018 05:36:02 UTC] PHP Stack trace:
[16-Jul-2018 05:36:02 UTC] PHP   1. {main}() /app/public/wp-admin/post.php:0
[16-Jul-2018 05:36:02 UTC] PHP   2. include() /app/public/wp-admin/post.php:174
[16-Jul-2018 05:36:02 UTC] PHP   3. do_meta_boxes() /app/public/wp-admin/edit-form-advanced.php:714
[16-Jul-2018 05:36:02 UTC] PHP   4. call_user_func:{/app/public/wp-admin/includes/template.php:1063}() /app/public/wp-admin/includes/template.php:1063
[16-Jul-2018 05:36:02 UTC] PHP   5. Give_MetaBox_Form_Data->output() /app/public/wp-admin/includes/template.php:1063
[16-Jul-2018 05:36:02 UTC] PHP   6. give_render_field() /app/public/wp-content/plugins/Give/includes/admin/forms/class-metabox-form-data.php:795
[16-Jul-2018 05:36:02 UTC] PHP   7. give_chosen_input() /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php:214
[16-Jul-2018 05:36:02 UTC] PHP   8. array_fill_keys() /app/public/wp-content/plugins/Give/includes/admin/give-metabox-functions.php:324

raftaar1191 · 2018-07-16T05:55:34Z

Finding

@mehul0810 still getting the error but this time its diff. This issue exists in PHP version 5.3

Debug log

[16-Jul-2018 05:52:53 UTC] PHP Warning:  array_fill_keys() expects parameter 1 to be array, string given in /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php on line 799
[16-Jul-2018 05:52:53 UTC] PHP Stack trace:
[16-Jul-2018 05:52:53 UTC] PHP   1. {main}() /app/public/wp-admin/edit.php:0
[16-Jul-2018 05:52:53 UTC] PHP   2. require_once() /app/public/wp-admin/edit.php:10
[16-Jul-2018 05:52:53 UTC] PHP   3. do_action() /app/public/wp-admin/admin.php:224
[16-Jul-2018 05:52:53 UTC] PHP   4. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453
[16-Jul-2018 05:52:53 UTC] PHP   5. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310
[16-Jul-2018 05:52:53 UTC] PHP   6. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286
[16-Jul-2018 05:52:53 UTC] PHP   7. Give_Admin_Settings->output() /app/public/wp-includes/class-wp-hook.php:286
[16-Jul-2018 05:52:53 UTC] PHP   8. include() /app/public/wp-content/plugins/Give/includes/admin/class-admin-settings.php:263
[16-Jul-2018 05:52:53 UTC] PHP   9. do_action() /app/public/wp-content/plugins/Give/includes/admin/views/html-admin-settings.php:109
[16-Jul-2018 05:52:53 UTC] PHP  10. WP_Hook->do_action() /app/public/wp-includes/plugin.php:453
[16-Jul-2018 05:52:53 UTC] PHP  11. WP_Hook->apply_filters() /app/public/wp-includes/class-wp-hook.php:310
[16-Jul-2018 05:52:53 UTC] PHP  12. call_user_func_array:{/app/public/wp-includes/class-wp-hook.php:286}() /app/public/wp-includes/class-wp-hook.php:286
[16-Jul-2018 05:52:53 UTC] PHP  13. Give_Settings_Page->output() /app/public/wp-includes/class-wp-hook.php:286
[16-Jul-2018 05:52:53 UTC] PHP  14. Give_Admin_Settings::output_fields() /app/public/wp-content/plugins/Give/includes/admin/abstract-admin-settings-page.php:230

…d once saved #3466"

Revert "fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466"

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466

* release/2.2: fix(admin-tools): return array data type fix(form): stop comment moderation emails fix(admin-tools): fix PHP notices fix(admin-donor): added first option of title prefix to disabled fix(admin-setting): fix error with admin setting title prefix fix(admin-form): improve code using sprintf and double quotes fix(admin-setting): fix admin setting title prefix notice fix(admin-setting): remove unnecessary double quotes fix(admin-form): fix empty title prefixes saving issue Revert "fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466" fix(admin-form): fix php notice related when value is not array

…d once saved #3466"

ravinderk assigned Sidsector9 Jul 13, 2018

ravinderk added this to the Sprint: 2018/07/11 - 2018/07/24 milestone Jul 13, 2018

raftaar1191 mentioned this issue Jul 13, 2018

qa(give): ensure quality of Give 2.2 #3467

Closed

33 tasks

Sidsector9 mentioned this issue Jul 13, 2018

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466 #3472

Closed

3 tasks

ravinderk assigned mehul0810 and unassigned Sidsector9 Jul 13, 2018

mehul0810 mentioned this issue Jul 13, 2018

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466 #3475

Merged

3 tasks

ravinderk mentioned this issue Jul 16, 2018

fix(give-settings): fix PHP notices when viewing give setting page #3476

Closed

ravinderk closed this as completed in #3475 Jul 16, 2018

ravinderk added a commit that referenced this issue Jul 16, 2018

Merge pull request #3475 from WordImpress/issue/fix/3466

0783185

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466

ravinderk reopened this Jul 16, 2018

mehul0810 added a commit that referenced this issue Jul 16, 2018

Revert "fix(admin-form): 2.2 ensure name title prefixes can be remove…

b541c93

…d once saved #3466"

mehul0810 added a commit that referenced this issue Jul 16, 2018

Merge pull request #3478 from WordImpress/revert-3475-issue/fix/3466

e2b8ce3

Revert "fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466"

mehul0810 mentioned this issue Jul 16, 2018

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466 #3479

Merged

3 tasks

ravinderk closed this as completed in #3479 Jul 16, 2018

ravinderk added a commit that referenced this issue Jul 16, 2018

Merge pull request #3479 from WordImpress/issue/fix/3466

298a052

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466

ravinderk pushed a commit that referenced this issue Jul 20, 2018

Revert "fix(admin-form): 2.2 ensure name title prefixes can be remove…

31c3b64

…d once saved #3466"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466

samsmith89 commented Jul 12, 2018

Server Environment

Give Configuration

Active Give Add-ons

Other Active Plugins

Inactive Plugins

Active MU Plugins

Theme

ravinderk commented Jul 13, 2018

ravinderk commented Jul 13, 2018

raftaar1191 commented Jul 16, 2018

raftaar1191 commented Jul 16, 2018

raftaar1191 commented Jul 16, 2018

ravinderk commented Jul 16, 2018

ravinderk commented Jul 16, 2018

raftaar1191 commented Jul 16, 2018

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466

fix(admin-form): 2.2 ensure name title prefixes can be removed once saved #3466

Comments

samsmith89 commented Jul 12, 2018

User Story

Current Behavior

Expected Behavior

Steps to Reproduce

Visuals

Related

Environment

Server Environment

Give Configuration

Active Give Add-ons

Other Active Plugins

Inactive Plugins

Active MU Plugins

Theme

ravinderk commented Jul 13, 2018

ravinderk commented Jul 13, 2018

raftaar1191 commented Jul 16, 2018

Finding

raftaar1191 commented Jul 16, 2018

Debug Log

raftaar1191 commented Jul 16, 2018

ravinderk commented Jul 16, 2018

ravinderk commented Jul 16, 2018

raftaar1191 commented Jul 16, 2018

Finding

Debug log