Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope: Add subscriptions to give core #6173

Merged
merged 17 commits into from
Feb 7, 2022

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jan 17, 2022

Resolves #6166

Description

This scope is a collection of PRs outlines below that introduces subscriptions as a core concept.

Affects

  • New LegacySubscriptions domain with give-recurring classes migrated

Testing Instructions

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit and/or end-to-end tests
  • Self Review of code and UX completed

@JasonTheAdams
Copy link
Contributor

@jonwaldstein Please resolve the merge conflicts so we can merge this.

@jonwaldstein jonwaldstein marked this pull request as ready for review February 2, 2022 15:16
@jonwaldstein
Copy link
Contributor Author

@JasonTheAdams merge conflicts fixed, this scope is ready.

@JasonTheAdams JasonTheAdams merged commit 0f95d8c into develop Feb 7, 2022
@JasonTheAdams JasonTheAdams deleted the scope/migrate-addon-concepts-into-core branch February 7, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscriptions should be a core concept
2 participants