Refactor: Default form #7616
Merged
Refactor: Default form #7616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IVE-1949 # Conflicts: # src/Campaigns/Actions/LoadCampaignDetailsAssets.php # src/Campaigns/Models/Campaign.php
| $defaultForm = $this->forms() | ||
| ->where('campaign_forms.is_default', true) | ||
| ->get(); | ||
|
|
||
| if (is_null($defaultForm)) { | ||
| $defaultForm = $this->legacyForms() | ||
| ->where('campaign_forms.is_default', true) | ||
| ->get(); | ||
| } | ||
|
|
||
| return $defaultForm; | ||
| return give(DonationFormsRepository::class)->getById($this->defaultFormId); |
|
This is exactly what I was hoping for. This cleaned things up so much. Always good to see a PR that results in less, faster code. 💪 |
5 tasks
kjohnson
reviewed
Nov 11, 2024
|
There is a new test failure that we need to address:
See https://github.com/impress-org/givewp/actions/runs/11936509340/job/33270320353?pr=7616 |
kjohnson
approved these changes
Dec 3, 2024
glaubersilva
reviewed
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the logic of getting and setting the default form. The default form id is now property of a campaign. The existing
form_idcolumn is used as a default form id column - this way we don't have to refactor P2P. Also, Campaign'sformsanddefaultFormmethods are refactored. Theformsmethod now returns both V2 and V3 forms.Affects
Campaign migrations
Campaign model
Campaign repository
Pre-review Checklist
@unreleasedtags included in DocBlocks