-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0 – Revive and bugfixes #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This large PR covers various updates aiming to revive this package and perform some smaller bugfixes.
Thes changes mainly aim at preparng the text-importer packages for the modifications necessary as part of Impresso II, which contain both the integration of new importers, and the corrections of various issues identified in the canonical data.
The modifications include:
requirements.txt
, and loosening version restrictions (using>=
instead of==
) to reduce the number of inconsistencies possible.pyproject.toml
instead ofsetup.py
.apply_select_func()
function ingeneric_importer.py
which was never called.codecs.open()
by the native pythonio.open()
function when possible, and setting a retrying approach when the error came formos.listdir()
.mets.parse_mets_amdsec()
when an element is not found in the XML file.issue.xml
orpage.xml
when parsing, especially in for loops, as this could create a computing overhead. Note: this appraoch could be extended to more cases as part of a separate issue..readthedocs.yaml
file.docs
folder that will be known once this PR is open.Closes #121.
As a consequence of the various changes, the version was bumped to 1.0.0.