Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rero bugfix #75

Merged
merged 4 commits into from
Jan 23, 2020
Merged

Rero bugfix #75

merged 4 commits into from
Jan 23, 2020

Conversation

ehoelzl
Copy link
Collaborator

@ehoelzl ehoelzl commented Jan 22, 2020 •
edited
Loading

This PR fixes the bug related to image coordinates for RERO (Mets/Alto flavor) #72 :

  • Image coordinates (c) are fetched from ALTO files when parsing the mets in order to add them to the issue JSON's content items
  • Image url (iiif_link) is also added to the issue data

@ehoelzl ehoelzl requested review from mromanello and e-maud January 22, 2020 11:57
@ehoelzl ehoelzl self-assigned this Jan 22, 2020
mromanello
mromanello approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@mromanello mromanello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good! actually we could/should use check_image_coordinates in the other tests as well.

@mromanello mromanello merged commit 3457dbc into master Jan 23, 2020
@mromanello mromanello deleted the RERO-bugfix branch January 23, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mromanello mromanello mromanello approved these changes

@e-maud e-maud Awaiting requested review from e-maud

Assignees

@ehoelzl ehoelzl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehoelzl @mromanello