Notify users that this repo is in maintenance mode #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there, I've recently been trying to figure out the open source proto infrastructure, which in itself has been pretty hard to navigate -- but I noticed that @johanbrandhorst has commented on multiple recent issues with this quote. > Please note that this repo is in maintenance mode, and we recommend users migrate to the official grpc-web client: https://github.com/grpc/grpc-web. It's interesting that it doesn't seem to suggest this anywhere on the README, and I didn't really figure out that this was the suggested path (by the maintainers of this repo) until digging deeper while debugging some stuff. In the end, it's totally up to you, but it seems to me like this would be something useful to put at the top of the README, so this PR just copy-pastes that quote (feel free to adjust formatting / wording as desired). Cheers, and thanks for your work.
improbable-prow-robot
added
the
size/XS
johanbrandhorst
approved these changes
Feb 9, 2023
|
I think there should be a caveat to this recommendation in that the official client does not yet support binary streams. I switched to their client and ended up switching back because processing for my project was too slow over grpc-web-text. I intend to stick with this client until theres implements it. |
|
I'd recommend switching to Connect nowadays. https://connect.build |
Thank you for the suggestion -- I'll check it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, I've recently been trying to figure out the open source proto infrastructure, which in itself has been pretty hard to navigate -- but I noticed that @johanbrandhorst has commented on multiple recent issues with this quote.
It's interesting that it doesn't seem to suggest this anywhere on the README, and I didn't really figure out that this was the suggested path (by the maintainers of this repo) until digging deeper while debugging some stuff. In the end, it's totally up to you, but it seems to me like this would be something useful to put at the top of the README, so this PR just copy-pastes that quote (feel free to adjust formatting / wording as desired).
Cheers, and thanks for your work.
Changes
Verification