Correct generated client, bidi stream method stubs #131
Conversation
johanbrandhorst
force-pushed
the
patch-1
branch
from
c63b3d2 to
f2c13f4
Compare
|
@jonny-improbable should be a simple merge I hope. |
johanbrandhorst
force-pushed
the
patch-1
branch
from
f2c13f4 to
60d257f
Compare
|
I've found another problem, lets wait with merging this please. |
|
@jonny-improbable ok there we go. |
src/service/grpcweb.ts
Outdated
| @@ -222,13 +222,13 @@ function generateTypescriptDefinition(fileDescriptor: FileDescriptorProto, expor | |||
| printer.printIndentedLn(`on(type: 'end', handler: () => void): RequestStream<T>;`); | |||
| printer.printIndentedLn(`on(type: 'status', handler: (status: Status) => void): RequestStream<T>;`); | |||
| printer.printLn(`}`); | |||
| printer.printLn(`interface BidirectionalStream<T> {`); | |||
| printer.printIndentedLn(`write(message: T): BidirectionalStream<T>;`); | |||
| printer.printLn(`interface BidirectionalStream<Req, Res> {`); | |||
There was a problem hiding this comment.
I'd like to know opinions on the Generic type variables here, but I can't use <R, R>, and I think <T, V> is just unclear.
There was a problem hiding this comment.
Maybe <ReqT, ResT>?
There was a problem hiding this comment.
Yep ReqT and ResT work for me
|
My formatter has formatted the files I've touched, I can try and revert those changes and keep the edits minimal if required. |
There was a problem hiding this comment.
Thanks for fixing this up, some pretty silly bugs in there from me 😋
This hints that the project would benefit from a proper integration test against an actual grpc-web server...
If you wouldn't mind reverting the whitespace changes then I'll be happy to merge
Thanks again
johanbrandhorst
force-pushed
the
patch-1
branch
from
86d4fe1 to
5187c4e
Compare
johanbrandhorst
changed the title
johanbrandhorst
force-pushed
the
patch-1
branch
from
5187c4e to
93c4444
Compare
|
@jonnyreeves should be good now (should I @jonnyreeves or @jonny-improbable?). |
|
Both work 😁 |
|
Published as (0.7.8-pre.217169b) |
…e-eng#131)" This reverts commit 0a44695.
It appears we were using the responseType instead of the requestType when creating the stream.
Fixes #132, #133