Swap onStatus to invoke BEFORE onEnd rather than after #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonny-improbable
approved these changes
Apr 2, 2019
|
Published to npm as 0.9.1-pre.c8a573d
…On Tue, 2 Apr 2019, 19:24 Jonny Reeves, ***@***.***> wrote:
Merged #159 <#159>
into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMN-aSrRWg0FhFgfdNzCVC46Jj9VoAhks5vc6B2gaJpZM4cW5sB>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
implemented changes specified in #155
Verification
There were 4 tests that broke with this change because they were explicitly expecting
onEndto come beforeonStatus, so I updated those. I also wrote 4 new tests to ensure that theonEndhandler is called with a status and that that status matches the one returned fromonStatus.