forked from space-wizards/space-station-14
-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose Antags Before Job Selection #1059
Draft
formlessnameless
wants to merge
19
commits into
impstation:master
Choose a base branch
from
formlessnameless:antag-selection-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Choose Antags Before Job Selection #1059
formlessnameless
wants to merge
19
commits into
impstation:master
from
formlessnameless:antag-selection-rework
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into antag-selection-rework
…into antag-selection-rework
…into antag-selection-rework
…into antag-selection-rework
…into antag-selection-rework
…nto antag-selection-rework
…into antag-selection-rework
…into antag-selection-rework
…into antag-selection-rework
…into antag-selection-rework
…into antag-selection-rework
…into antag-selection-rework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially makes it so all antag gamerules choose which player will be an antag before job selection runs. It gets all added gamerules, including pending ones, and then selects based on the player pool at the start of the round. There's still a LOT to test with this and I will probably make a bunch of changes as I revisit things but this seems to be a Technically Working Prototype. I wanted to get this draft up so other code knowledge havers could take a look and tell me if there's things I'm being stupid about. I know at the very least I want to add a bit that double checks the counts and adds more antags when each rule actually starts if the ratios are off.
🆑