Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secret reinforced walls #1167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FlippenPage
Copy link

adds secret reinforced walls

Changelog

🆑

  • add: secret reinforced walls

-adds secret reinforced walls
@hivehum
Copy link

hivehum commented Dec 30, 2024

idk about this one, for balance reasons

@iaada
Copy link

iaada commented Dec 30, 2024

Feels balanced enough to me. It can make secret walls a little harder to find, but that's also sort of the point of it. This PR is also useful for mappers in making maints secrets.

@@ -0,0 +1,132 @@
- type: entity
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these files need to be in our file structure btw

thresholds:
- trigger:
!type:DamageTrigger
damage: 200
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has the same damage thresholds as the non-reinforced secret door. if this is not intentional, it may be better to set it to be damage: 400, matching a reinforced wall

@hivehum
Copy link

hivehum commented Dec 30, 2024

deleted my FUCKINg rreply i hate it here. anyway my thot here wrt balance is that it is probably intentional that this doesnt exist upstream because then it makes it significantly easier to secret door your way into the captain's quarters/vault/whatever and leave zero trace. i dont feel super strongly about this ultimately, just something to think about

@mutanteggs
Copy link

mutanteggs commented Dec 30, 2024

deleted my FUCKINg rreply i hate it here. anyway my thot here wrt balance is that it is probably intentional that this doesnt exist upstream because then it makes it significantly easier to secret door your way into the captain's quarters/vault/whatever and leave zero trace. i dont feel super strongly about this ultimately, just something to think about

the reason it's not upstream is because it was bundled with a change to secret doors that put them in parity with TG secret doors, meaning they required nothing but steel to make

@Darkmajia
Copy link

i think its fine and good, makes secret walls more of an option in certain areas. does need things moved to our file structure, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants