Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machines and Computers become contraband #1168

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

iaada
Copy link

@iaada iaada commented Dec 30, 2024

This PR was originally about making the protolathe science contraband (see edit history), but has been expanded to mark many different machines and computers as department contraband. This has very little balance consideration besides the odd thief steal target (which was treated as theft when caught anyway).

Adding contraband tags is about reinforcing in-game what belongs where and who should have what. It doesn't actually stop anyone for giving people these items, but adds a sliver of conflict to the act. Bureaucracy and gentleman's agreements can resolve the conflict IC.

🆑 aada

  • tweak: Several machines and computers are now contraband.

@Darkmajia
Copy link

i dont think this will really stop anyone, but i guess i can appreciate the intention. people gotta stop handing those things out. i'll leave this for a little bit just in case anyone else wants to chime in

@iaada
Copy link
Author

iaada commented Dec 31, 2024

I am considering expanding this to more machines. It feels somewhat weird if it's just the one, when other machines are ostensibly department locked. Especially things like the SecFab, or a cargo request console.

@iaada iaada changed the title Protolate becomes science contraband Machines and Computers become contraband Dec 31, 2024
@iaada
Copy link
Author

iaada commented Dec 31, 2024

I followed through with my previous comment. I worry that it's a bit much, but at the same time protolathe being the only contraband machine didn't sit right either. It's possible I missed something or was overzealous so I'd like to hear comment on it, but as I said in the edited top comment this is purely a change to RP systems.

@mqole
Copy link

mqole commented Dec 31, 2024

cargo and engineering spawn with protolathes in some maps (unless i missed a maintainer memo). maybe hold off on merging until we confirm this at minimum
engineering also has access to a monitoring console roundstart in packed. maybe more

with these changes theres a sort of hazy implication that only members of that department are legally allowed to use the machine, which i'd love some more clarification on. is this the route we're going, or are we letting the existing id access requirements dictate all that?

@iaada
Copy link
Author

iaada commented Dec 31, 2024

So I mentioned this in the original post. There are some protolathes in cargo, which was the impetus for the conversation and change, and what the original discussion was meant to be about. Upstream wants to remove protolathes from cargo according to space-wizards#33947, the implication being that they don't want protolathes outside of science and that it's a product of low oversight on maps. We don't have to go the same direction as wizden, but at least personally I agree that protolathes don't belong outside science for RP and round flow reasons.

Packed has two of the contra computers in telecoms, but at least on a cursory glance I can't find any other map that does this. At any rate it's not at all common for those computers to be in engi.

My choices were a mix of things that simply don't exist or have a purpose outside of their department (engineering monitors, cargo), and ones that would be actively dangerous for civilians to have free access to (most of the science stuff like artifact crusher and A.P.E., or department lathes and station records).

I could implement some access requirements if we wanted to, and I'm not sure where I stand on that. At the least protolathes will continue to be handed out, and the bridge consoles would probably need cross department access (base + command). It makes me lean towards ID reqs not being super necessary. Plenty of other department contraband isn't id locked.

As for crime, I feel possession is all that needs to be considered. Possession can broadly include things like building the machine in a department it doesn't belong in, or in your maints cave. And if you're not in possession of this machine, then the only times you're going to be able to use it illegally is when you're already illegally trespassing.

@hivehum
Copy link

hivehum commented Jan 1, 2025

this looks fine to me. i don't feel strongly about it and ultimately the way it is implemented is entirely flavor atm. i definitely do not think access restrictions should be added; the additional contraband tags are enough

ill leave this up to the two game admins who commented previously on if they want it approved since currently this is going to mostly be a moderation concern if its added

@Darkmajia
Copy link

i definitely think access restrictions are not the way to go, but i like the expanded scope of this pr overall. i'll review it properly tomorrow unless someone gets to it before me

Copy link

@Darkmajia Darkmajia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@Darkmajia Darkmajia merged commit 8f09106 into impstation:master Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants