Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube: add support for OAuth2 tokens #558

Merged
merged 8 commits into from
Jun 8, 2024
Merged

youtube: add support for OAuth2 tokens #558

merged 8 commits into from
Jun 8, 2024

Conversation

dumbmoron
Copy link
Member

No description provided.

dumbmoron added 3 commits June 8, 2024 09:19

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
it never really worked

Verified

This commit was signed with the committer’s verified signature.
@dumbmoron dumbmoron requested a review from wukko June 8, 2024 09:30

Verified

This commit was signed with the committer’s verified signature.
fuck off deepsource
@wukko
Copy link
Member

wukko commented Jun 8, 2024

i think generation script should be moved to a different directory, something like src/tooling

@wukko
Copy link
Member

wukko commented Jun 8, 2024

i'd also show a message that access token is sensitive info and shouldn't be shown to or shared with anyone

@wukko wukko changed the title youtube: add support for using OAuth2 tokens youtube: add support for OAuth2 tokens Jun 8, 2024
dumbmoron added 3 commits June 8, 2024 11:52

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@dumbmoron dumbmoron requested a review from wukko June 8, 2024 11:59
package.json Show resolved Hide resolved

Verified

This commit was signed with the committer’s verified signature.
Copy link
Member

@wukko wukko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wukko
Copy link
Member

wukko commented Jun 8, 2024

does not fully close #551, but improves the situation by a lot

@wukko wukko merged commit a434de0 into current Jun 8, 2024
4 checks passed
@dumbmoron dumbmoron deleted the yt-tokens branch June 8, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants