Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/debug: add a copy button, fix page padding, refactor #782

Merged
merged 9 commits into from
Oct 11, 2024

Conversation

alectrocute
Copy link
Contributor

@alectrocute alectrocute commented Sep 27, 2024

In this PR:

  • Use i18n
  • Add "Copy" button to make debug sections easier to copy
  • Iterate through array for sections instead
Screenshot 2024-09-27 at 12 48 04 PM

@alectrocute alectrocute changed the title feat: debug/+page.svelte – use translations, add copy button, iterate through array for template web/Debug – use translations, add copy button, iterate through array for template Sep 27, 2024
@alectrocute alectrocute changed the title web/Debug – use translations, add copy button, iterate through array for template web/Debug: Use translations, add copy button, iterate through array for template Sep 27, 2024
@wukko
Copy link
Member

wukko commented Oct 3, 2024

what about making a copy button just like the one used for copying links to sections?

image

just gotta give the copy icon component the regularIcon prop so that regular copy button is shown instead of the link one.

i also think it's a good idea to remove the colon in the section title

@alectrocute
Copy link
Contributor Author

@wukko Done and done! Let me know if you need any further changes on this.

@alectrocute alectrocute changed the title web/Debug: Use translations, add copy button, iterate through array for template web/debug: Use translations, add copy button, iterate through array for template Oct 3, 2024
@alectrocute
Copy link
Contributor Author

@wukko Changes made!

@alectrocute alectrocute requested a review from wukko October 4, 2024 14:24
@wukko wukko changed the title web/debug: Use translations, add copy button, iterate through array for template web/debug: add a copy button, fix page padding, refactor Oct 11, 2024
@wukko wukko merged commit dc12d6a into imputnet:main Oct 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants