Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arguments of make_block_pulse are highly confusing #149

Closed
wtclarke opened this issue Nov 13, 2023 · 3 comments
Closed

Arguments of make_block_pulse are highly confusing #149

wtclarke opened this issue Nov 13, 2023 · 3 comments
Assignees
@sravan953

Comments

@wtclarke
Copy link
Contributor

wtclarke commented Nov 13, 2023 •
edited
Loading

bandwidth, the second listed argument (default=0) has no effect (see relevant logic), unless the the default to duration (default = 4E-3) is overwritten by the user. This isn't documented anywhere, no warning is issued, and duration is listed several places below bandwidth in the list of arguments.
@sravan953
Copy link
Collaborator

Thanks for this, @wtclarke ! Would you be interested in submitting a PR wherein a warning is raised?

@wtclarke wtclarke mentioned this issue Nov 14, 2023
Merged
@wtclarke
Copy link
Contributor Author

Done in #151 . I've also added markers for the tests, so only the tests we expect to work will run.

@wtclarke
Copy link
Contributor Author

Closed in #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sravan953 sravan953

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sravan953 @wtclarke