Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small bugfixes #165

Merged
merged 11 commits into from
Jan 30, 2024
Merged

A few small bugfixes #165

merged 11 commits into from
Jan 30, 2024

Conversation

FrankZijlstra
Copy link
Collaborator

@FrankZijlstra FrankZijlstra commented Jan 18, 2024

  • Fixed some rounding errors in Sequence
  • Fixed possible warning for invalid escape sequence (e.g. "(\s)+" -> r"(\s)+")
  • Fixed reading back in string definitions that contain spaces (e.g. seq.set_definition("a", "a a"))
  • Fixed an error in calculate_kspace when there are gradients specified on a gradient axis, but there are no ramps (i.e. all gradients are 0)

Edit, two more small bugs:

  • Fixed an error with next_free_block_ID calculation when reading an empty sequence
  • Fixed a bug in traj_to_grad and allow it to be used with a multidimensional k-space array

@FrankZijlstra
Copy link
Collaborator Author

Added a small fix for #166

@FrankZijlstra
Copy link
Collaborator Author

And one more: Fixed a bug in make_trapezoid that gave an error with a negative flat_area (introduced in #146)

@btasdelen btasdelen merged commit bae4c51 into imr-framework:dev Jan 30, 2024
4 checks passed
@FrankZijlstra FrankZijlstra deleted the bugfixes branch February 5, 2024 10:13
@schuenke schuenke mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants