Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes in make_extended_trapezoid and add_gradients #167

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

FrankZijlstra
Copy link
Collaborator

Fixed two small bugs:

  • Missing area field in make_extended_trapezoid
  • Extrapolation bug in add_gradients when adding arbitrary gradients

Copy link
Collaborator

@schuenke schuenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@schuenke
Copy link
Collaborator

schuenke commented Feb 6, 2024

a22879a is correct as well

I leave the PR open for the moment in case you find some more bugs, but feel free to squash merge it whenever you want @FrankZijlstra

@schuenke schuenke merged commit 20cce84 into imr-framework:dev Feb 7, 2024
4 checks passed
@FrankZijlstra FrankZijlstra deleted the bugfixes branch May 31, 2024 13:12
@schuenke schuenke mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants