Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added possibility to configure displaynames of temperatures #34

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

koelle25
Copy link

Hi @imrahil,

as the OctoPrint webinterface layout doesn't offer a lot of width I have added options to the settings so that one can configure which name should be displayed beneath the temperatures - so that it can be shorter if one wants (e.g. when using this plugin in conjunction with DisplayLayerProgress.

Here is a screenshot for an example (my personal configuration):
2018-05-14 19_29_42-anet a8 octoprint

I think this is a cool addition and would love if you accept my PR.

Regards,
Kevin

@Cosik
Copy link
Collaborator

Cosik commented Mar 13, 2020

@koelle25 are you still want to add this features? If yes please resolve merge conflits and then we could make a review.

@spacecabbie
Copy link

this is indeed a nice addition @koelle25 if you are to busy mind if i pick it up and fix ?

@koelle25
Copy link
Author

@spacecabbie For sure you can! I hadn't had the chance and passion to look into all those conflicts which came up with time (this PR is now almost 2 years old).
I guess I'll have to add you to my fork as a collaborator, is that right?

@spacecabbie
Copy link

@spacecabbie For sure you can! I hadn't had the chance and passion to look into all those conflicts which came up with time (this PR is now almost 2 years old).
I guess I'll have to add you to my fork as a collaborator, is that right?

Yes if you want to keep credit for the change. I can just copy it as a new commit but that it would show up under my name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants