Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delimiters to raw output #175

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

sigmaSd
Copy link
Collaborator

@sigmaSd sigmaSd commented Jul 13, 2020

This is useful for external programs that wants to parse the output.
Without a delimiter like its currently the case, its impossible (as far as I know) to parse it correctly.
Also visually it looks more organized.

@imsnif
Copy link
Owner

imsnif commented Jul 14, 2020

Well, I thought one could parse it according to the timestamps, but it would definitely be easier this way. :)

I'm wondering: do you think it would make sense to only print Refreshing in case there's actual data? Or do you think it would be more convenient for the user to be aware that there was a refresh without any new data? I'm on the fence on this one, tbh :)

@sigmaSd
Copy link
Collaborator Author

sigmaSd commented Jul 14, 2020

I had the exact same hesitation :p I just ended up copying what nethogs does. But now that I think more about it, I think it would look better without those blank refreshing, what about something like "Refreshing:\n no data.." or do you prefer it removed?

@imsnif
Copy link
Owner

imsnif commented Jul 14, 2020

I like that idea. How about making it "Refreshing:\n no traffic"?

@imsnif
Copy link
Owner

imsnif commented Jul 14, 2020

Maybe something like <NO TRAFFIC> to make it clearer? Not sure. Whatever you feel looks good :)

@sigmaSd sigmaSd force-pushed the add_delimiters_to_raw_output branch from edc9aa9 to b5d33bd Compare July 14, 2020 12:48
@sigmaSd
Copy link
Collaborator Author

sigmaSd commented Jul 14, 2020

I think <NO TRAFFIC> looks good indeed!

Copy link
Owner

@imsnif imsnif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks again! :)

@imsnif imsnif merged commit 93a6178 into imsnif:main Jul 14, 2020
@sigmaSd
Copy link
Collaborator Author

sigmaSd commented Jul 14, 2020

Thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants