feat: add `PID` column to `Process` table #379

notjedi · 2024-03-15T04:06:26Z

closes #159

cyqsimon · 2024-03-15T04:56:10Z

Hi there; thanks a lot for the PR.

I took a quick look and the code looks pretty good. But it seems like you are still making changes so I'll let you cook. Just request my review and/or ping me when you're ready 😊

ref: #165 (comment)

notjedi · 2024-03-15T05:21:04Z

hi @cyqsimon, thanks for taking a look at the code. i think i'm done now. can you please review the code?

PS: one thing i'm not able to figure out is the newlines disappearing in the snapshots.

This reverts commit e5f06cb. We will do this separately for the sake of keeping a clean history

cyqsimon

Thanks again for your good work. I've got a few suggestions:

src/os/lsof_utils.rs

src/os/shared.rs

src/os/windows.rs

cyqsimon · 2024-03-15T14:41:58Z

Also, I have reverted e5f06cb for now so that we can keep the history clean. We can do that separately.

As of the disappearing new lines in the snapshots, it's probably a quirk of our TUI lib ratatui. I really don't know. Not a problem though because the lack of these lines simply means "no updates on these lines this frame".

cyqsimon · 2024-03-17T10:22:56Z

The other test failures you see here are due to a race condition during program termination. This is a known problem, and I'm working on it, however long that may eventually take... It's okay to ignore the failures with known reasons.

cyqsimon · 2024-03-18T05:29:39Z

Lgtm. Let's merge!

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [imsnif/bandwhich](https://github.com/imsnif/bandwhich) | minor | `v0.22.2` -> `v0.23.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>imsnif/bandwhich (imsnif/bandwhich)</summary> ### [`v0.23.0`](https://github.com/imsnif/bandwhich/releases/tag/v0.23.0) [Compare Source](imsnif/bandwhich@v0.22.2...v0.23.0) #### Casuistry. It's a cool word isn't it? This release is mostly bug fixes and maintainability changes with 1 minor feature: - Add PID column to the process table [#379](imsnif/bandwhich#379) - [@notjedi](https://github.com/notjedi) A big rewrite of the main loop is still forthcoming™️. #### What's Changed - CI: strip release binaries for all targets by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#358 - CI: include generated assets in release archive by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#359 - chore(deps): bump clap_mangen from 0.2.17 to 0.2.18 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#361 - chore(deps): bump strum from 0.25.0 to 0.26.1 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#362 - chore(deps): bump itertools from 0.12.0 to 0.12.1 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#363 - Remove redundant imports by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#377 - CI: use GitHub API to exempt dependabot from changelog requirement by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#378 - chore(deps): bump clap from 4.4.18 to 4.5.1 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#373 - chore(deps): bump thiserror from 1.0.56 to 1.0.57 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#366 - chore(deps): bump log from 0.4.20 to 0.4.21 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#367 - chore(deps): bump insta from 1.34.0 to 1.35.1 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#371 - chore(deps): bump tokio from 1.35.1 to 1.36.0 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#370 - chore(deps): bump anyhow from 1.0.79 to 1.0.80 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#369 - chore(deps): bump chrono from 0.4.33 to 0.4.34 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#372 - chore(deps): bump clap_mangen from 0.2.18 to 0.2.20 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#374 - chore(deps): bump clap-verbosity-flag from 2.1.2 to 2.2.0 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#375 - chore(deps): bump clap_complete from 4.4.9 to 4.5.1 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#376 - chore(deps): bump ratatui from 0.25.0 to 0.26.1 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#368 - chore(deps): bump mio from 0.8.10 to 0.8.11 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#380 - feat: add `PID` column to `Process` table by [@notjedi](https://github.com/notjedi) in imsnif/bandwhich#379 - Remove unnecessary logging synchronisation by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#381 - Apply suggestions from new clippy lint `clippy::assigning_clones` by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#382 - Fix IPv6 socket detect logic by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#383 - CI: Configure dependabot grouping by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#395 - chore(deps): bump the dependencies group with 10 updates by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#396 - Enable Android build by [@flxo](https://github.com/flxo) in imsnif/bandwhich#384 - docs: add Exherbo Linux install instructions in README.md by [@davlgd](https://github.com/davlgd) in imsnif/bandwhich#398 - CI refactor by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#399 - Fix Windows FP discrepancy issue in test by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#400 - CI: Remove `musl-tools` install step by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#402 - Keep GitHub Actions up to date with GitHub's Dependabot by [@cclauss](https://github.com/cclauss) in imsnif/bandwhich#403 - chore(deps): bump actions/upload-artifact from 3 to 4 in the github-actions group by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#404 - chore(deps): bump the dependencies group with 6 updates by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#405 - Temporarily disable UI tests by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#406 - CI: Enable more cross-compiled builds by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#401 - Add logo by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#330 - Update README by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#407 - CI: use sccache to speed up CI by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#408 - Update usage in README by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#409 - chore(deps): bump taiki-e/cache-cargo-install-action from 1 to 2 in the github-actions group by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#411 - chore(deps): bump mozilla-actions/sccache-action from 0.0.4 to 0.0.5 in the github-actions group by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#415 - chore(deps): bump the dependencies group across 1 directory with 19 updates by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#416 - chore(deps): bump openssl from 0.10.64 to 0.10.66 by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#417 - chore(deps): bump the dependencies group with 14 updates by [@dependabot](https://github.com/dependabot) in imsnif/bandwhich#418 - Update `sysinfo` API calls by [@cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#421 #### New Contributors - [@notjedi](https://github.com/notjedi) made their first contribution in imsnif/bandwhich#379 - [@flxo](https://github.com/flxo) made their first contribution in imsnif/bandwhich#384 - [@davlgd](https://github.com/davlgd) made their first contribution in imsnif/bandwhich#398 - [@cclauss](https://github.com/cclauss) made their first contribution in imsnif/bandwhich#403 **Full Changelog**: imsnif/bandwhich@v0.22.2...v0.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

notjedi added 5 commits March 15, 2024 09:34

feat: add PID column to Process table

5913523

fix(tests): populate fake data with the correct ProcessInfo type

63f609f

test: update snapshots

c3e7f55

refactor: use more idiomatic rust

1d9bd14

refactor: rename function from get_proc_name to get_proc_info

2ac0700

notjedi added 2 commits March 15, 2024 10:30

refactor: only display PID when width available is highest

d24b939

ref: #165 (comment)

tests: update snapshots

35f6743

notjedi and others added 3 commits March 15, 2024 17:28

chore: update CHANGELOG

cd35f5c

fix: clippy warnings

e5f06cb

Revert "fix: clippy warnings"

94cc14a

This reverts commit e5f06cb. We will do this separately for the sake of keeping a clean history

cyqsimon requested changes Mar 15, 2024

View reviewed changes

src/os/lsof_utils.rs Outdated Show resolved Hide resolved

src/os/shared.rs Outdated Show resolved Hide resolved

src/os/windows.rs Outdated Show resolved Hide resolved

notjedi added 2 commits March 18, 2024 10:10

refactor: use u32 for PID

bf62915

refactor: more idiomatic rust

009263f

cyqsimon approved these changes Mar 18, 2024

View reviewed changes

cyqsimon merged commit 1997bce into imsnif:main Mar 18, 2024
9 of 12 checks passed

cyqsimon mentioned this pull request Mar 25, 2024

Apply suggestions from new clippy lint clippy::assigning_clones #382

Merged

BrewTestBot mentioned this pull request Aug 17, 2024

bandwhich 0.23.0 Homebrew/homebrew-core#181463

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `PID` column to `Process` table #379

feat: add `PID` column to `Process` table #379

notjedi commented Mar 15, 2024 •

edited

Loading

cyqsimon commented Mar 15, 2024

notjedi commented Mar 15, 2024

cyqsimon left a comment

cyqsimon commented Mar 15, 2024 •

edited

Loading

cyqsimon commented Mar 17, 2024

cyqsimon commented Mar 18, 2024

feat: add PID column to Process table #379

feat: add PID column to Process table #379

Conversation

notjedi commented Mar 15, 2024 • edited Loading

cyqsimon commented Mar 15, 2024

notjedi commented Mar 15, 2024

cyqsimon left a comment

Choose a reason for hiding this comment

cyqsimon commented Mar 15, 2024 • edited Loading

cyqsimon commented Mar 17, 2024

cyqsimon commented Mar 18, 2024

feat: add `PID` column to `Process` table #379

feat: add `PID` column to `Process` table #379

notjedi commented Mar 15, 2024 •

edited

Loading

cyqsimon commented Mar 15, 2024 •

edited

Loading