fix some inspections (#33)

imsweb · Jun 16, 2020 · 1e686d5 · 1e686d5
1 parent 9c4712c
commit 1e686d5
Showing 1 changed file with 18 additions and 18 deletions.
diff --git a/src/main/java/com/imsweb/x12/writer/X12Writer.java b/src/main/java/com/imsweb/x12/writer/X12Writer.java
@@ -15,26 +15,26 @@
 
 public class X12Writer {
 
-    private static List<Loop> _DATA_LOOPS;
-    private static Separators _SEPARATORS;
-    private static TransactionDefinition _DEFINITION;
+    private final List<Loop> _dataLoops;
+    private final Separators _separators;
+    private final TransactionDefinition _definition;
 
     public X12Writer(FileType fileType, List<Loop> loops, Separators separators) {
-        _DATA_LOOPS = loops;
-        _DEFINITION = fileType.getDefinition();
-        _SEPARATORS = separators;
+        _dataLoops = loops;
+        _definition = fileType.getDefinition();
+        _separators = separators;
     }
 
     public X12Writer(FileType fileType, List<Loop> loops) {
-        _DATA_LOOPS = loops;
-        _DEFINITION = fileType.getDefinition();
-        _SEPARATORS = new Separators();
+        _dataLoops = loops;
+        _definition = fileType.getDefinition();
+        _separators = new Separators();
     }
 
     public X12Writer(X12Reader reader) {
-        _DATA_LOOPS = reader.getLoops();
-        _DEFINITION = reader.getDefinition();
-        _SEPARATORS = reader.getSeparators();
+        _dataLoops = reader.getLoops();
+        _definition = reader.getDefinition();
+        _separators = reader.getSeparators();
     }
 
 
@@ -55,15 +55,15 @@ public String toX12String() {
      * @return X12 formatted string representing this X12 reader.
      */
     public String toX12String(LineBreak lineBreak) {
-        _SEPARATORS.setLineBreak(lineBreak);
+        _separators.setLineBreak(lineBreak);
         return toX12StringImpl();
     }
 
     private String toX12StringImpl() {
         StringBuilder builder = new StringBuilder();
-        for (Loop loop : _DATA_LOOPS) {
-            builder.append(loop.toX12String(_DEFINITION.getLoop()));
-            builder.append(_SEPARATORS.getLineBreak().getLineBreakString());
+        for (Loop loop : _dataLoops) {
+            builder.append(loop.toX12String(_definition.getLoop()));
+            builder.append(_separators.getLineBreak().getLineBreakString());
         }
         return builder.toString();
     }
@@ -75,8 +75,8 @@ private String toX12StringImpl() {
      */
     public String toHtml() {
         StringBuilder builder = new StringBuilder();
-        for (Loop loop : _DATA_LOOPS) {
-            builder.append(loop.toHtml(_DEFINITION.getLoop(), new ArrayList<>()));
+        for (Loop loop : _dataLoops) {
+            builder.append(loop.toHtml(_definition.getLoop(), new ArrayList<>()));
         }
         return builder.toString();
     }