Optimize parsing #14

angelaszek · 2019-09-13T20:30:59Z

Optimizes the parsing process to better handle large X12 files.

Closes #13

#13)

ctmay4

Just some comments on null handling in the new separator methods.

src/main/java/com/imsweb/x12/Separators.java

src/test/java/com/imsweb/x12/SeparatorsTest.java

# Conflicts: # build.gradle # gradle/wrapper/gradle-wrapper.properties

src/main/java/com/imsweb/x12/Separators.java

ctmay4

More questions in Separators.java

src/main/java/com/imsweb/x12/Separators.java

angelaszek added 10 commits August 30, 2019 12:59

dealing with large files

c3431ec

dealing with large files

9ab2665

first pass of making storing claim data more efficient (#13)

6cf11c0

fix validation checks, add unit tests back in, include footer segments (

ad1fbe4

#13)

Incoporate multiple GS - all unit tests now pass (#13)

dee2a80

Remove unused method (#13)

9a398c8

Remove unused import (#13)

bf3388d

Remove unused import (#13)

3768d98

Some cleanup (#13)

ff46252

Some additional tests and minor changes for error reporting (#13)

2d70910

angelaszek requested a review from ctmay4 September 13, 2019 20:31

angelaszek and others added 10 commits September 16, 2019 23:14

Simplify some code - add detailed unit test (#13)

550be7e

Add error check (#13)

f4b8f88

Minor update to .gitignore.

fe3b59f

Switch snapshot name

a446c34

Simplify structure - only use lists and make it data driven (#13)

4a8c8d0

Update Gradle wrapper

77d5d64

Split using patterns (#13)

97d57de

Add splitting unit tests (#13)

ebec42f

Update SNAPSHOT version for a release.

a079b8a

Update version number to non-snapshot (#13)

fea8da7

ctmay4 requested changes Oct 2, 2019

View reviewed changes

src/main/java/com/imsweb/x12/Separators.java Show resolved Hide resolved

src/test/java/com/imsweb/x12/SeparatorsTest.java Show resolved Hide resolved

ctmay4 assigned angelaszek Oct 2, 2019

ctmay4 added the enhancement label Oct 2, 2019

ctmay4 changed the title ~~Cache by claim (#13)~~ Optimize parsing Oct 2, 2019

angelaszek added 3 commits October 2, 2019 18:03

Adding null checks (#13)

3f75cab

Don't need to check the patterns for null (#13)

b59fa42

Removed assumption that separators can't be null and updated tests (#13)

0a68861

angelaszek assigned ctmay4 and unassigned angelaszek Oct 2, 2019

Merge branch 'master' into cache-by-claim-13

607c765

# Conflicts: # build.gradle # gradle/wrapper/gradle-wrapper.properties

ctmay4 reviewed Oct 3, 2019

View reviewed changes

src/main/java/com/imsweb/x12/Separators.java Show resolved Hide resolved

ctmay4 requested changes Oct 3, 2019

View reviewed changes

src/main/java/com/imsweb/x12/Separators.java Outdated Show resolved Hide resolved

Remove unnecessary method (#13)

b1176f1

ctmay4 approved these changes Oct 3, 2019

View reviewed changes

ctmay4 merged commit 36bd5a6 into master Oct 3, 2019

ctmay4 deleted the cache-by-claim-13 branch October 3, 2019 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize parsing #14

Optimize parsing #14

angelaszek commented Sep 13, 2019 •

edited by ctmay4

Loading

ctmay4 left a comment

ctmay4 left a comment

Optimize parsing #14

Optimize parsing #14

Conversation

angelaszek commented Sep 13, 2019 • edited by ctmay4 Loading

ctmay4 left a comment

Choose a reason for hiding this comment

ctmay4 left a comment

Choose a reason for hiding this comment

angelaszek commented Sep 13, 2019 •

edited by ctmay4

Loading