Issue 21 serialize back to x12 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the correct order.
…e_x12 # Conflicts: # build.gradle
angelaszek
reviewed
Mar 2, 2020
added 5 commits
March 4, 2020 11:29
we need a check to confirm that the loop we get from getLoop is actually a direct child of the current loop we are processing from the LoopDefinition.
|
@angelaszek please re-review. thanks. |
|
@ctmay4 , ready for re-review in case you were interested in doing so. thanks. |
angelaszek
reviewed
Mar 6, 2020
|
@angelaszek fixed the test as you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #21