Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X12 string from loop #35

Merged
merged 8 commits into from
Jun 22, 2020
Merged

X12 string from loop #35

merged 8 commits into from
Jun 22, 2020

Conversation

angelaszek
Copy link
Collaborator

@angelaszek angelaszek commented Jun 22, 2020

@ctmay4 can you review this? I created a method that can take X12Loops and output X12 text from it. We can use it to create synthetic data files in DMS. I moved some of the existing writer methods to a new X12Writer class. It seemed strange to have output methods in a "reader" class. There were no changes to the reading/parsing of X12 files.

Closes #33

@angelaszek angelaszek requested a review from ctmay4 June 22, 2020 13:36
Copy link
Member

@ctmay4 ctmay4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ctmay4 ctmay4 merged commit 2279931 into master Jun 22, 2020
@ctmay4 ctmay4 changed the title X12 string from loop 33 X12 string from loop Jun 22, 2020
@ctmay4 ctmay4 deleted the x12_string_from_loop-33 branch June 22, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create X12 String Output from Loop
2 participants