fix: handle corrupted config files gracefully instead of crashing #118
Conversation
- Use default values when config options are missing instead of throwing - Regenerate config automatically when options are missing or malformed - Add TRUNCATE_EXISTING to prevent leftover data from corrupting config - Remove System.exit(1) on config parse errors to allow recovery Fixes imthosea#115
There was a problem hiding this comment.
Pull request overview
This PR fixes crashes caused by corrupted config files by implementing graceful recovery with default values. When config options are missing or the config file cannot be parsed, the mod will now use default values and automatically regenerate the config file instead of crashing with IllegalStateException.
Key changes:
- Replace crash-on-parse-error behavior with graceful recovery using default values
- Automatically regenerate config when options are missing or file is corrupted
- Add
TRUNCATE_EXISTINGflag to prevent file corruption from leftover data
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ConfigLoadContext.java | Removes System.exit(1) call on config load failure, adds hasMissingOptions flag to track missing config options, and changes missing option handling from throwing exceptions to logging warnings and using defaults |
| Config.java | Adds hasMissingOptions check to config regeneration condition and adds TRUNCATE_EXISTING flag to prevent incomplete writes from leaving corrupted leftover data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| LOGGER.warn("Config option {} not found - using default value. Config will be regenerated.", name); | ||
| hasMissingOptions = true; | ||
| } |
There was a problem hiding this comment.
While this change handles missing options correctly, it doesn't address malformed option values (e.g., "tru" instead of "true" or "enabl" as shown in issue #115). When a config option exists but has a malformed value, boolOrDefault and intOrDefault will still throw IllegalStateException, causing the same crash this PR aims to fix. Consider also catching these exceptions and setting hasMissingOptions=true to trigger config regeneration, or return the default value after logging a warning.
2 participants
Fixes #115