fix: handle corrupted config files gracefully instead of crashing #119
Conversation
- Use default values when config options are missing instead of throwing - Regenerate config automatically when options are missing or malformed - Add TRUNCATE_EXISTING to prevent leftover data from corrupting config - Remove System.exit(1) on config parse errors to allow recovery Fixes imthosea#115
There was a problem hiding this comment.
Pull request overview
This PR aims to make the application more robust by handling corrupted or malformed config files gracefully instead of crashing. The changes allow the application to recover from config errors by using default values and automatically regenerating the config file.
Key changes:
- Removed
System.exit(1)call when config loading fails, allowing the application to continue with default values - Added
hasMissingOptionsflag to track when config options are missing and trigger automatic regeneration - Added
TRUNCATE_EXISTINGflag when writing config to prevent leftover data from corrupting the file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ConfigLoadContext.java | Added missing options tracking, removed fatal error exit, and changed missing option handling to log warnings instead of throwing exceptions |
| Config.java | Updated config regeneration condition to include missing options case and added TRUNCATE_EXISTING flag to file write operation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| LOGGER.warn("Config option {} not found - using default value. Config will be regenerated.", name); | ||
| hasMissingOptions = true; | ||
| } |
There was a problem hiding this comment.
The exceptions thrown in boolOrDefault (line 50) and intOrDefault (lines 62, 65) when config values are malformed are not handled. These exceptions will prevent the graceful recovery that this PR aims to provide. When a config value is malformed (e.g., "maybe" instead of "true"/"false", or "abc" instead of a number), the application will still crash instead of using the default value.
1 participant
Fixes #115