fix: handle corrupted config files gracefully instead of crashing #122
Conversation
- Use default values when config options are missing instead of throwing - Regenerate config automatically when options are missing or malformed - Add TRUNCATE_EXISTING to prevent leftover data from corrupting config - Remove System.exit(1) on config parse errors to allow recovery Fixes imthosea#115
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of config file handling by gracefully recovering from corrupted or incomplete configuration files instead of crashing the application. The changes allow the application to continue running with default values when config issues are detected, and automatically regenerate the config file.
Key changes:
- Removed
System.exit(1)calls when config parsing fails, allowing recovery instead of crashing - Added tracking for missing config options via
hasMissingOptionsflag to trigger automatic regeneration - Added
TRUNCATE_EXISTINGflag to file writing to prevent partial data corruption
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| common/src/main/java/me/thosea/badoptimizations/config/ConfigLoadContext.java | Added hasMissingOptions flag, removed System.exit(1) on config load failure, changed missing option handling from throwing exceptions to logging warnings and using defaults |
| common/src/main/java/me/thosea/badoptimizations/config/Config.java | Added hasMissingOptions check to config regeneration condition, added TRUNCATE_EXISTING to prevent leftover data corruption |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| LOGGER.warn("Config option {} not found - using default value. Config will be regenerated.", name); | ||
| hasMissingOptions = true; | ||
| } |
There was a problem hiding this comment.
When str() returns null due to a missing config option, hasMissingOptions is set to true. However, if a config value is malformed (e.g., a boolean option has an invalid value, or an integer option is not a valid number or is negative), the code in boolOrDefault() and intOrDefault() throws IllegalStateException without setting hasMissingOptions = true. This means malformed values won't trigger automatic config regeneration as described in the PR. Consider catching these exceptions and setting hasMissingOptions = true to ensure malformed values also trigger regeneration.
2 participants
Fixes #115