fix: handle corrupted config files gracefully instead of crashing #123
Conversation
- Use default values when config options are missing instead of throwing - Regenerate config automatically when options are missing or malformed - Add TRUNCATE_EXISTING to prevent leftover data from corrupting config - Remove System.exit(1) on config parse errors to allow recovery Fixes imthosea#115
There was a problem hiding this comment.
Pull request overview
This PR improves config file corruption handling by implementing graceful recovery instead of crashing the application. When a config file is corrupted or has missing/malformed options, the system now logs warnings and regenerates the config with default values.
Key changes:
- Removes
System.exit(1)call when config loading fails, allowing recovery - Adds
hasMissingOptionsflag to track when options are missing and trigger regeneration - Adds
TRUNCATE_EXISTINGflag to prevent leftover data from corrupting regenerated configs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ConfigLoadContext.java | Removes fatal error handling, adds tracking for missing options, and returns null to allow fallback to defaults |
| Config.java | Adds condition to regenerate config when options are missing, includes TRUNCATE_EXISTING to ensure clean config writes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if(str == null) { | ||
| throw new IllegalStateException("Config option " + name + " not found"); | ||
| LOGGER.warn("Config option {} not found - using default value. Config will be regenerated.", name); | ||
| hasMissingOptions = true; | ||
| } |
There was a problem hiding this comment.
The boolOrDefault and intOrDefault methods still throw IllegalStateException for malformed values (e.g., invalid boolean strings or non-numeric values). This is inconsistent with the PR's goal of handling corrupted configs gracefully. When these exceptions are thrown, they will propagate up and potentially crash the application during static initialization. Consider catching these exceptions and setting hasMissingOptions to true, or returning the default value and logging a warning instead.
2 participants
Fixes #115