Reduce common drivers to support 1180 MCUs #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teburd
approved these changes
Nov 22, 2024
|
Makes sense, I guess questions start coming up with how does the mcux sdk deal with these peripheral block revisions/differences, I guess some ifdef's in C... |
|
Thank you for starting too look into this @mciantyre ! |
The moved drivers were common across all supported MCUs. But these peripherals aren't available on the 1180. Lower these drivers into the chips category so they can be re-exported as needed. This change is backwards compatible. End users won't (shouldn't) notice our changed module structure. The drivers left behind in common should truly be common with the 1180. I'll separately introduce imxrt-ral consolidations so we can get a baseline 1180 build.
Remove 'family' from the layers. Each chip module now brings in the specific drivers it supports. We move all of these kinds of drivers into a drivers directory. The configuration module lives inline, within the chip module.
The family category doesn't make much sense when the 1180 is so different from the 1170. Rewrite all conditional compiles in terms of chips.
The hal_led example can turn on the LED. We can't even blink that LED
yet! At least our runtime, build system, and supporting libraries are
working.
Here's how to build and program the example. You'll need a probe-rs
build that supports the 1180.
cargo build --features=board/imxrt1180evk-cm33 --target=thumbv8m.main-none-eabihf --example=hal_led --release
probe-rs run --chip=mimxrt1189 target/thumbv8m.main-none-eabihf/release/examples/hal_led
mciantyre
force-pushed
the
rt1180-common
branch
from
7464ecc to
ca25e95
Compare
|
No rush to review. We're still playing around with ideas. I integrated your team's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1180 has different GPIO and PIT peripherals. There's no SVNS equivalent (or there is and I haven't found it). Lower those modules and their dependent modules into
chip, and re-export them for all supporting MCUs.Once we reduce what's common, we can start to support the 1180. I added a CI job to show a successful build. See imxrt-rs/imxrt-ral#52 for the accompanying imxrt-ral changes.