Add the S3MUA to the 1189 RAL #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can still emit the `number` function if there's just one instance. We've been doing this for sole instance types, so this maintains backwards compatibility. If there are multiple peripherals associated with the same block, and if they're not numbered, then we can treat them as distinct. We abuse the const generics to stamp out unique type aliases, and we start counting backwards from 255. We signal through documentation that this const generic is meaningless. There's other ways to do this; one way is to introduce a unique type state to the generic `Instance`. By default, use `()`. Then let implementations define their own type state when they specify their instance aliases, thus generating unique types with the same "sole instance" const generic. It's more code to take this approach, and I'm time limited.
Depends on the previous commit to relax raltool code generation requirements. Haven't tested this on hardware, and I barely studied the SVD contents. The starting addresses match the reference manual contents, and the smoke test passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't tested this on hardware, and I haven't studied the
imxrt-ralblock. But the starting addresses match the reference manual contents.This requires us to relax the code generation requirements in
raltoolto permit un-numbered instance groups. See the commit message for details and alternatives.