Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go validator APIs for Provenance v1 predicate #287

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

marcelamelara
Copy link
Contributor

@marcelamelara marcelamelara commented Sep 25, 2023

This PR adds Validate() functions for the SLSA Provenance v1 Go bindings, per the SLSA Provenance v1 spec, as well as basic tests.

Note: This PR is a blocker for ITE-6/ITE-9 integration in in-toto-golang: in-toto/in-toto-golang#268.

@marcelamelara marcelamelara requested a review from a team as a code owner September 25, 2023 19:02
@marcelamelara marcelamelara force-pushed the add-provenance-validators branch from aedbff9 to 43f3d9b Compare September 25, 2023 19:05
Copy link
Member

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits else LGTM

go/predicates/provenance/v1/provenance.go Outdated Show resolved Hide resolved
go/predicates/provenance/v1/provenance.go Outdated Show resolved Hide resolved
go/predicates/provenance/v1/provenance.go Outdated Show resolved Hide resolved
go/predicates/provenance/v1/provenance.go Outdated Show resolved Hide resolved
go/predicates/provenance/v1/provenance.go Outdated Show resolved Hide resolved
go/predicates/provenance/v1/provenance.go Outdated Show resolved Hide resolved
go/predicates/provenance/v1/provenance.go Outdated Show resolved Hide resolved
go/predicates/provenance/v1/provenance.go Outdated Show resolved Hide resolved
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
@marcelamelara marcelamelara force-pushed the add-provenance-validators branch from 5aea664 to 6a10854 Compare October 10, 2023 14:53
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@TomHennen TomHennen merged commit 2713540 into in-toto:main Oct 13, 2023
2 checks passed
@marcelamelara marcelamelara deleted the add-provenance-validators branch August 30, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants