Add error returns if command invalid in RunCommand #124 #125
Conversation
|
Hi @u5surf sorry, I just realized we were working on the same PR at the same time :D |
| @@ -240,6 +240,10 @@ command execution. | |||
| */ | |||
| func RunCommand(cmdArgs []string, runDir string) (map[string]interface{}, error) { | |||
|
|
|||
| if cmdArgs == nil || len(cmdArgs) == 0 { | |||
There was a problem hiding this comment.
It is actually not that easy.. this would lead to an error if cmdArgs is empty.
The in-toto python implementation allows empty cmdArgs, hence we need a fix in both functions. Like here:
https://github.com/in-toto/in-toto-golang/pull/126/files
|
@u5surf do you want to adopt my PR in https://github.com/in-toto/in-toto-golang/pull/126/files? See: https://github.com/in-toto/in-toto-golang/pull/126/files |
Close this PR. |
Please fill in the fields below to submit a pull request. The more
information that is provided, the better.
Fixes issue #:
Fixes #124
Description of pull request:
RunCommand has not validation to delegate to exec.Command, so I added simple validation that has checked cmdArgs length and nil.
Please verify and check that the pull request fulfills the following
requirements:
I consider that it is a trivial bug fix, so I'm not willing to write CHANGE.LOG
If you feel like to write anything in docs, it is welcome for me about this :-)