-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirect for release predicate #23
Conversation
Signed-off-by: Zach Steindler <steiza@github.com>
I think it might be better for predicate redirects to just point to cc @in-toto/attestation-maintainers |
Yes, I agree that the predicates links should point to main, rather than a version tag. This also avoids having to keep re-specifying predicate URLs on each new spec-wide release tag. I'll update my PR on the /attestation end as well. +1 to merging after the predicate PR is merged. |
Signed-off-by: Zach Steindler <steiza@github.com>
8d3f22e
to
c4a905f
Compare
Hi, bumping this PR as the final requirement (merge of the related PR) was met a while ago. Thanks! |
All: can someone submit an official review for this PR? |
By the way, are any of these redirects actually used (I don't see them in the website files), and if so, where? |
These redirects point to corresponding files in another repo: https://github.com/in-toto/attestation/tree/main/spec/predicates These are spec files for different types of in-toto metadata, so the purpose of the redirects is to make the schema resolvable from any metadata file. |
As requested in in-toto/attestation#319 and detailed in in-toto/attestation#320.
I'm not exactly sure how this should work. I'm assuming that after in-toto/attestation#319 lands, there would be a v1.0.2 release cut of https://github.com/in-toto/attestation/, and then this PR should land?
Definitely open to feedback here.