Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec clarifications #75

Merged
merged 4 commits into from
May 3, 2023
Merged

Spec clarifications #75

merged 4 commits into from
May 3, 2023

Conversation

adityasaky
Copy link
Member

@adityasaky adityasaky commented Apr 5, 2023 •
edited
Loading

This PR includes more spec clarifications and some formatting changes. Highlights:

  • integration of accepted ITEs into the spec
  • clarifications about keytypes enumerated in the spec
  • specifies types of patterns used in artifact rules
  • clarifies require rule can also result in rule processing erroring out like disallow

The PR also optimistically bumps the version to 1.0-RC!

Closes #45, #71, #72.

JustinCappos
JustinCappos reviewed Apr 6, 2023
View reviewed changes
in-toto-spec.md Outdated Show resolved Hide resolved
JustinCappos
JustinCappos approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This set of changes look fine to me. I did not go through ITEs 1-5 carefully to ensure that they are all well integrated into this version of the spec. I believe that is necessary before this becomes the finalized 1.0 version...

@adityasaky adityasaky mentioned this pull request Apr 6, 2023
Closed
@adityasaky
Clarify parts of the spec pre v1.0
cdc977a 
Signed-off-by: Aditya Sirish <aditya@saky.in>
@adityasaky
Add mention of glob for artifact rule patterns
eac5d7e 
Signed-off-by: Aditya Sirish <aditya@saky.in>
lukpueh
lukpueh approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but they aren't blockers.

in-toto-spec.md Outdated Show resolved Hide resolved
in-toto-spec.md Show resolved Hide resolved
in-toto-spec.md Show resolved Hide resolved
@adityasaky
Rephrase ITE adherence, use artifact name instead of path
6bea197 
Signed-off-by: Aditya Sirish <aditya@saky.in>
@adityasaky
Copy link
Member Author

#45 may be a blocker.

@lukpueh
Copy link
Member

lukpueh commented Apr 12, 2023

#45 may be a blocker.

Blocker for 1.0, but not for this PR, right?

@adityasaky adityasaky requested a review from lukpueh April 12, 2023 14:12
@adityasaky
Note that require rule can error out during rule processing
7479530 
Signed-off-by: Aditya Sirish <aditya@saky.in>
@adityasaky
Copy link
Member Author

Blocker for 1.0, but not for this PR, right?

I've updated the require rule bits as well and I think we've now clarified how it works.

lukpueh
lukpueh approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements!

@adityasaky adityasaky mentioned this pull request Apr 25, 2023
Open
SantiagoTorres
SantiagoTorres approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@SantiagoTorres SantiagoTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is quite tighter!

@adityasaky
Copy link
Member Author

Shall we merge and tag RC?

@JustinCappos JustinCappos merged commit 86e337f into in-toto:master May 3, 2023
This was referenced May 3, 2023
Closed
Open
@adityasaky adityasaky deleted the more-pre-v1-edits branch May 3, 2023 13:31
@adityasaky adityasaky mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukpueh lukpueh lukpueh approved these changes

@JustinCappos JustinCappos JustinCappos approved these changes

@SantiagoTorres SantiagoTorres SantiagoTorres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expected python in-toto to consume 'REQUIRE' layout item.
4 participants
@adityasaky @lukpueh @JustinCappos @SantiagoTorres