Checking attestors for duplicates #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
jkjell
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Looks good so far. Could we add a test in https://github.com/in-toto/witness/blob/main/cmd/run_test.go? I think we're good then.
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Done! |
jkjell
reviewed
Jan 17, 2024
jkjell
reviewed
Jan 17, 2024
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
jkjell
approved these changes
Jan 17, 2024
ChaosInTheCRD
added a commit
to ChaosInTheCRD/witness
that referenced
this pull request
Jan 19, 2024
* prevents duplicate attestors * adding tests * modified help for attestations flag --------- Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
ChaosInTheCRD
added a commit
to ChaosInTheCRD/witness
that referenced
this pull request
Jan 19, 2024
* prevents duplicate attestors * adding tests * modified help for attestations flag --------- Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
ChaosInTheCRD
added a commit
to ChaosInTheCRD/witness
that referenced
this pull request
Jan 19, 2024
* prevents duplicate attestors * adding tests * modified help for attestations flag --------- Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
ChaosInTheCRD
added a commit
that referenced
this pull request
Jan 25, 2024
* starting proposed restructure Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * adding latest changes to README Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * fixed link to contributing md Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * made title title heading size Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * named the file wrong - doh Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * resizing headings at top Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * added spacing Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * a few more fixes Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * adding background section Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * removing bullet Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * final neatening Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * updated docs further - tutorial not working Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * adding demo gif Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * adding docusaurus stuff and more progress Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * saving progress, including docusaurus website Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * changing logo Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * adding snowfall Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * adding the concepts section Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * Adding the contributing.md from archivista (#327) * adding the contributing.md from archivista * dont need jq Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * Migrating go module (#328) * added all imports * fixing go sum * changing go-witness back for now, makes more sense --------- Co-authored-by: John Kjell <john@testifysec.com> Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * Migrating to the use of in-toto/go-witness module (#331) * added all imports * fixing go sum * changing go-witness back for now, makes more sense * moved witness to using new in-toto/go-witness module Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * adding change to test now following newer version of policy * running docgen as changes found from use of new module * pinning to v0.2.0 of archivista and go-witness Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> --------- Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> Signed-off-by: Tom Meadows <tom@tmlabs.co.uk> * Bumping Go version for goreleaser (#333) bumping go version for goreleaser Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * chore: bump actions/download-artifact from 3.0.2 to 4.0.0 (#335) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3.0.2 to 4.0.0. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@9bc31d5...7a1cd32) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump github/codeql-action from 2.22.9 to 3.22.11 (#336) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.9 to 3.22.11. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@c0d1daa...b374143) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: John Kjell <john@testifysec.com> * chore: bump actions/upload-artifact from 3.1.3 to 4.0.0 (#337) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@a8a3f3a...c7d193f) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: John Kjell <john@testifysec.com> * chore: bump github/codeql-action from 3.22.11 to 3.22.12 (#343) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.22.11 to 3.22.12. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b374143...012739e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump actions/download-artifact from 4.0.0 to 4.1.0 (#342) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@7a1cd32...f44cd7b) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * moving config doc Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * adding latest changes Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * saving progress Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * adding keyless signing tutorial Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * doing images Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * fixing broken image Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * changing url Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * fixed images Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * updating docs and removing witness.md Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * Update go-git to resolve vulnerability (#346) * Update go-git to resolve vulnerability Signed-off-by: John Kjell <john@testifysec.com> * Update x/crypto Signed-off-by: John Kjell <john@testifysec.com> --------- Signed-off-by: John Kjell <john@testifysec.com> * chore: bump actions/dependency-review-action from 3.1.4 to 3.1.5 (#349) * Add FOSSA license scanning Signed-off-by: John Kjell <john@testifysec.com> * Add Security MD files an add FOSSA scan badge Signed-off-by: John Kjell <john@testifysec.com> Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * Pin dependencies and restrict permissions Signed-off-by: John Kjell <john@testifysec.com> * Add signing to goreleaser and Best Practices badge to readme. Signed-off-by: John Kjell <john@testifysec.com> Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * Add cosign install Signed-off-by: John Kjell <john@testifysec.com> * Update cloudflare/circl due to dependabot failure (#352) Signed-off-by: John Kjell <john@testifysec.com> * updated package json Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * chore: bump actions/cache from 3.3.2 to 3.3.3 (#355) Bumps [actions/cache](https://github.com/actions/cache) from 3.3.2 to 3.3.3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@704facf...e12d46a) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump actions/upload-artifact from 4.0.0 to 4.1.0 (#356) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@c7d193f...1eb3cb2) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump github/codeql-action from 3.22.12 to 3.23.0 (#357) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.22.12 to 3.23.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@012739e...e5f05b8) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump actions/download-artifact from 4.1.0 to 4.1.1 (#358) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@f44cd7b...6b208ae) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Initial attempt at PR and Issue templates (#351) * Initial attempt at PR and Issue templates Signed-off-by: John Kjell <john@testifysec.com> * Address some review feedback Signed-off-by: John Kjell <john@testifysec.com> --------- Signed-off-by: John Kjell <john@testifysec.com> Co-authored-by: Tom Meadows <tom@tmlabs.co.uk> * Checking attestors for duplicates (#361) * prevents duplicate attestors * adding tests * modified help for attestations flag --------- Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * removing witness website for now Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * editing image links Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * updating docgen Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * fixing docgen Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * addressing comments Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * fixing small issue with md Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> * fixed ellipsis Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> --------- Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> Signed-off-by: Tom Meadows <tom@tmlabs.co.uk> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: John Kjell <john@testifysec.com> Co-authored-by: John Kjell <john@testifysec.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick recreation of #332 as some DCO signoff was missing.