[FEATURE] Add type and autocomplete information to input fields

This helps accessibility, autocompletion, and usage on mobile devices. Also fix an incorrect type. https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete Releases: v7, main
in2code-de · May 20, 2024 · 8b56d40 · 8b56d40
1 parent 9dbaf72
commit 8b56d40
Show file tree

Hide file tree

Showing 15 changed files with 18 additions and 14 deletions.
diff --git a/Resources/Private/Partials/Fields/Address.html b/Resources/Private/Partials/Fields/Address.html
@@ -11,6 +11,6 @@
  id="femanager_field_address"
  property="address"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'address')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'street-address'}, settings: settings, fieldName: 'address')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/City.html b/Resources/Private/Partials/Fields/City.html
@@ -11,6 +11,6 @@
  id="femanager_field_city"
  property="city"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'city')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'address-level2'}, settings: settings, fieldName: 'city')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/Company.html b/Resources/Private/Partials/Fields/Company.html
@@ -11,6 +11,6 @@
  id="femanager_field_company"
  property="company"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'company')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'organization'}, settings: settings, fieldName: 'company')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/DateOfBirth.html b/Resources/Private/Partials/Fields/DateOfBirth.html
@@ -14,6 +14,6 @@
  placeholder="{f:translate(key:'tx_femanager_domain_model_user.dateOfBirth.placeholder')}"
  title="{f:translate(key:'tx_femanager_domain_model_user.dateOfBirth.hint')}"
  value="{user.dateOfBirth -> f:format.date(format:'{f:translate(key:\'tx_femanager_domain_model_user.dateFormat\')}')}"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'dateOfBirth')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'bday'}, settings: settings, fieldName: 'dateOfBirth')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/Email.html b/Resources/Private/Partials/Fields/Email.html
@@ -11,6 +11,7 @@
  id="femanager_field_email"
  property="email"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'email')}" />
+ type="email"
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'email'}, settings: settings, fieldName: 'email')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/Fax.html b/Resources/Private/Partials/Fields/Fax.html
@@ -11,6 +11,7 @@
  id="femanager_field_fax"
  property="fax"
  class="form-control"
+ type="tel"
  additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'fax')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/FirstName.html b/Resources/Private/Partials/Fields/FirstName.html
@@ -11,6 +11,6 @@
  id="femanager_field_firstName"
  property="firstName"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'firstName')}" />
+ additionalAttributes="{additionalAttributes: {autocomplete: 'given-name'}, femanager:Validation.FormValidationData(settings: settings, fieldName: 'firstName')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/LastName.html b/Resources/Private/Partials/Fields/LastName.html
@@ -11,6 +11,6 @@
  id="femanager_field_lastName"
  property="lastName"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'lastName')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'family-name'}, settings: settings, fieldName: 'lastName')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/MiddleName.html b/Resources/Private/Partials/Fields/MiddleName.html
@@ -11,6 +11,6 @@
  id="femanager_field_middleName"
  property="middleName"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'middleName')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'additional-name'}, settings: settings, fieldName: 'middleName')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/Name.html b/Resources/Private/Partials/Fields/Name.html
@@ -11,6 +11,6 @@
  id="femanager_field_name"
  property="name"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'name')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'name'}, settings: settings, fieldName: 'name')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/Telephone.html b/Resources/Private/Partials/Fields/Telephone.html
@@ -11,6 +11,7 @@
  id="femanager_field_telephone"
  property="telephone"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'telephone')}" />
+ type="tel"
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'tel'}, settings: settings, fieldName: 'telephone')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/Title.html b/Resources/Private/Partials/Fields/Title.html
@@ -11,6 +11,6 @@
  id="femanager_field_title"
  property="title"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'title')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'organization-title'}, settings: settings, fieldName: 'title')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/Username.html b/Resources/Private/Partials/Fields/Username.html
@@ -11,6 +11,6 @@
  id="femanager_field_username"
  property="username"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'username')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'username'}, settings: settings, fieldName: 'username')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/Www.html b/Resources/Private/Partials/Fields/Www.html
@@ -11,6 +11,7 @@
  id="femanager_field_www"
  property="www"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'www')}" />
+ type="url"
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'url'}, settings: settings, fieldName: 'www')}" />
  </div>
 </div>
diff --git a/Resources/Private/Partials/Fields/Zip.html b/Resources/Private/Partials/Fields/Zip.html
@@ -11,6 +11,6 @@
  id="femanager_field_zip"
  property="zip"
  class="form-control"
- additionalAttributes="{femanager:Validation.FormValidationData(settings: settings, fieldName: 'zip')}" />
+ additionalAttributes="{femanager:Validation.FormValidationData(additionalAttributes: {autocomplete: 'postal-code'}, settings: settings, fieldName: 'zip')}" />
  </div>
 </div>