[TASK] Make search in file module case-insensitive #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://projekte.in2code.de/issues/62123 Resolves: https://projekte.in2code.de/issues/62160 Resolves: https://projekte.in2code.de/issues/62309 Resolves: https://projekte.in2code.de/issues/62310 Resolves: https://projekte.in2code.de/issues/62320 Resolves: https://projekte.in2code.de/issues/62547 Resolves: https://projekte.in2code.de/issues/62718 Resolves: https://projekte.in2code.de/issues/62738 Resolves: https://projekte.in2code.de/issues/62739 Resolves: https://projekte.in2code.de/issues/62883 Resolves: https://projekte.in2code.de/issues/62884 Resolves: https://projekte.in2code.de/issues/62886 Resolves: https://projekte.in2code.de/issues/62894 Resolves: https://projekte.in2code.de/issues/62975 Resolves: https://projekte.in2code.de/issues/63066 Resolves: https://projekte.in2code.de/issues/63166 Resolves: https://projekte.in2code.de/issues/63386
The JavaScript-Based search in the file module is case sensitive. This is unusual for searches. Both the searched value as well as the searchable data are now transformed toLowerCase before comparison. Possible improvements are: - Applying that transformation in Fluid, trading having it to do every request server-side vs. not having to do it on the client for every search. - Implementing some kind of fuzzy search-logic.
|
Thanks for your contribution! Manually cherry-picked this into develop at 33242ec due to previous master commits being present in this PR for some reason. Also, please open Pull Requests against our default ( |
|
There being commits unmerged into develop is exactly why I switched it. I'll try to rebase onto develop if there is a next time 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JavaScript-Based search in the file module is case sensitive. This is unusual for searches.
Both the searched value as well as the searchable data are now transformed toLowerCase before comparison.
Possible improvements are: