Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang.org/x/crypto from 0.29.0 to 0.31.0 #117

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

aminvakil
Copy link
Collaborator

Bumps golang.org/x/crypto from 0.29.0 to 0.31.0.


updated-dependencies:

  • dependency-name: golang.org/x/crypto dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com
(cherry picked from commit 712ef8b)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.29.0 to 0.31.0.
- [Commits](golang/crypto@v0.29.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 712ef8b)
@aminvakil
Copy link
Collaborator Author

This PR addresses GHSA-v778-237x-gjrc .

I've closed it on my fork, it's better to be fixed here.

@aminvakil
Copy link
Collaborator Author

@hryamzik Can I DM you? Email, IRC, discord, telegram, whichever you're happier.

@hryamzik
Copy link
Collaborator

why?

@hryamzik hryamzik merged commit 7a29e3b into inCaller:master Dec 12, 2024
2 checks passed
@aminvakil aminvakil deleted the crypto-0.31.0 branch December 12, 2024 12:21
@aminvakil
Copy link
Collaborator Author

It's been more than 4 years (#52) since I'm maintaining this repository on my fork, mostly to have latest updates on a docker image of my own, push latest changes, and so on. You can checkout the fork yourself, not much is changed between here and there.

What do you think about maintaining the docker image (I mean docker image on a public repository) here, and then you can add me as a maintainer in this repository, and I'll deal with docker image, Dockerfile issues, and stuff.

I'm happy with my fork myself, and it's getting used daily and it's awesome, but maybe it's worth to get merged here after 4 years :) and join our efforts.

@hryamzik
Copy link
Collaborator

Granted you write access

@aminvakil
Copy link
Collaborator Author

Thanks that was quick!

I guess it's better not to use docker image in my name, and create a inCaller/prometheus_bot docker image, and I'd rather it's getting created by you, so you are the owner of the image, or inCaller organization.

Please tell me what to do from here, also please tell me if you'd rather talk about this in another issue.

@hryamzik
Copy link
Collaborator

I'd rather user github docker registry, I didn't check docs fully but looks like there's just a workflow file to be added.

@aminvakil
Copy link
Collaborator Author

Fine, I'll test this on my repository, then merge all the changes at last here.

@aminvakil aminvakil mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants