Adds transitions when switching views. #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if we switched views before the transition finished #content wound up in an inconsistent state or outside the viewport. We need to use .finish() when we upgrade jQuery to 1.9
|
Great patchset, looks good no me. |
|
Looks good no me |
|
Patchset is good, there are some fixes to do on animation.
|
|
can we get this merged already ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm splitting the stuff from stateful-views in smaller and not that intrusive changes.
Maybe this is not the best way to animate the changes but works for me and does not break the views.