Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media click adds #214

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Media click adds #214

wants to merge 5 commits into from

Conversation

pardo-bsso
Copy link
Member

Make MediaListView trigger events for single and double click.
When editing playlists double click on a media adds it to the playlist.

@xaiki
Copy link
Member

xaiki commented Feb 5, 2014

The click patch is OK
The double click one i don't like from a user perspective.
Better have a details button.

@pardo-bsso
Copy link
Member Author

On 5 February 2014 05:31, Niv Sardi notifications@github.com wrote:

The click patch is OK
The double click one i don't like from a user perspective.
Better have a details button.

Not sure I understand. I thought we wanted to add stuff on double
click? I'm seeing it in Marzo.org

@pardo-bsso
Copy link
Member Author

On 5 February 2014 05:34, Niv Sardi notifications@github.com wrote:
Why so much work ? This needs to be abstracted in pieces.

not sure if we agreed to that but we ended up doing the same inside
medialistview, perhaps it would be better if it takes care of that.

How about this?
https://github.com/inaes-tic/mbc-caspa/tree/media-click-adds-try2

@pardo-bsso pardo-bsso mentioned this pull request Feb 6, 2014
@xaiki
Copy link
Member

xaiki commented Mar 25, 2014

is this still valid ?

@pardo-bsso
Copy link
Member Author

On 25 March 2014 17:03, Niv Sardi notifications@github.com wrote:

is this still valid ?

I can rebase and mend it to apply again, but do we want this or not
besides being listed on Marzo?

@xaiki
Copy link
Member

xaiki commented Mar 27, 2014

On Tue, Mar 25 2014, notifications@github.com wrote:

On 25 March 2014 17:03, Niv Sardi notifications@github.com wrote:

is this still valid ?

I can rebase and mend it to apply again, but do we want this or not
besides being listed on Marzo?

one click yes,
double click no.

@pardo-bsso
Copy link
Member Author

On 27 March 2014 02:07, Niv Sardi notifications@github.com wrote:

On 25 March 2014 17:03, Niv Sardi notifications@github.com wrote:

is this still valid ?

I can rebase and mend it to apply again, but do we want this or not
besides being listed on Marzo?

one click yes,
double click no.

So, just to leave a trail. We want to add a media to the playlist
being edited with a single click on the main media list?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants