Think Bin's element with size is a module

[pvalsecc]

Here is some code:

Data = <<?KEEP_ALIVE:16>>.

KEEP_ALIVE is defined like that:

-define(KEEP_ALIVE, 10).

Elvis is a bit lost:

- Don't use macros (like KEEP_ALIVE on line 55) as module names.

Obviously, in the context of a Bin, KEEP_ALIVE is not used as a module name...

[jfacorro]

@pvalsecc The bug is supposed to be fixed in the branch jfacorro.172.macro.in.binary. Could you please confirm this is working for you?

git clone https://github.com/inaka/elvis
git checkout jfacorro.172.macro.in.binary
cd elvis
make
sudo make install
cd /path/to/project
elvis rock

Thanks!

[jfacorro]

@pvalsecc The change is now in master if you find that it is still not working for you please reopen this issue. Thanks!

[pvalsecc]

@jfacorro Sorry, I didn't see your question. Didn't get the email for some reason.

No, your patch is really not solving my issue.

In this example:

Data = <<?KEEP_ALIVE:16>>.

?KEEP_ALIVE is not used as module name at all. Everything that is in front of a colon is not necessarily a module. In the context of a Bin, this is just a value. And in this context a constant is OK.

[pvalsecc]

Sorry, I don't have permission to reopen an issue.

[jfacorro]

@pvalsecc That sucks 😞. Would it be possible for you to paste the whole function where the binary is used? It's a long shot but maybe the rule is not taking into account something regarding the context where this expression appears.

[pvalsecc]

For example, look at mqtt_protocol.erl line 77.

[jfacorro]

@pvalsecc Is it possible that the elvis version you have currently installed is outdated? I just ran the version in master in the erlangmqtt project and this is result I got.

[dvaergiller]

The problem also arises in the case where the size is a macro. This is interpreted as a macro as function:

Value:?VALUE_SIZE = Binary

[jfacorro]

@pvalsecc I think @dvaergiller addressed the problem for good. The expressions here are not considered as failures so we are closing this issue. Please let us know if you find any problems.

[pvalsecc]

@jfacorro , look at the elvis.conf file in the erlangmqtt root, I disabled macro_module_names because of this bug.
I'll test it monday to see if there is a new version of Elvis that fixes it.

[jfacorro]

@pvalsecc Oh, I see. I didn't check the elvis.config, sorry about that 😞.