halt(1) after 'elvis rock' invocation fails. #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes 'elvis rock' usable in e.g. continuous integration systems or other automation relying on the usual shell return codes to detect failure. Cf. #175 This change also: * fixes a couple of typos (unimplemened -> unimplemented, emtpy -> empty); * adds mocks for erlang_utils:erlang_halt around every invocation of main() that calls 'rocks'; * standardizes use of meck:unload/1 throughout - some were in 'catch' expressions, some not; this doesn't appear to be necessary.
elbrujohalcon
pushed a commit
that referenced
this pull request
Nov 19, 2014
halt(1) after 'elvis rock' invocation fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes 'elvis rock' usable in e.g. continuous integration systems or other
automation relying on the usual shell return codes to detect failure.
Cf. #175
This change also:
that calls 'rocks';
expressions, some not; this doesn't appear to be necessary.