Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#270] Implement no_debug_call rule. #282

Merged
merged 5 commits into from
Nov 5, 2015

Conversation

bullno1
Copy link
Contributor

@bullno1 bullno1 commented Oct 10, 2015

Should I add the rule to elvis.config too?

@elbrujohalcon
Copy link
Member

Add it to elvis.config please (with just io:format and ct:pal) and also to the rules page in the project wiki, if you haven't done that yet

@elbrujohalcon
Copy link
Member

👍 from me, although let's wait for @amilkr to review and merge it.

@jfacorro
Copy link
Contributor

@bullno1 Hi, thank you for your awesome contribution. The config/elvis.config configuration file is the one where all default Elvis rules are kept. There is also the wiki page that lists all Default Rules in Elvis Webhook. Could you please add the rule in that list as well?

@elbrujohalcon
Copy link
Member

@bullno1 any updates on this?

@bullno1
Copy link
Contributor Author

bullno1 commented Nov 5, 2015

Sorry for taking so long, it's done now.

@@ -0,0 +1 @@
sdsds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file, thanks.

jfacorro added a commit that referenced this pull request Nov 5, 2015
@jfacorro jfacorro merged commit 3f55a89 into inaka:master Nov 5, 2015
@bullno1 bullno1 deleted the no-debugging-call branch November 5, 2015 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants