change: full rework of TraceId (breaking change) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now can be any opaque string as specified by Honeycomb but will be generated as a UUID V4 and also prefer to be stored as a UUID. Adds many ways of converting to and from `TraceId`.
Honeycomb allows it's trace_id's to be _any arbitrary string_. Respect that, because we may be sent an id from some source we do not directly control, such as an edge proxy. This changes TraceId to avoid parsing, and to internally just hold a string. Unfortunately the tracing crate imposes restrictions that make this untenable for span ids. This also includes a rework of sampling, making it be deterministic for a given trace_id, and also allowing it to function on any string.
|
Unfortunately my need for this is production-level, and so I have created a fork for my employer - this is undesirable but we need it to interop with a framework crate published to crates.io and can't use git overrides. |
Fishrock123
added a commit
to eaze/preroll
that referenced
this pull request
Feb 17, 2021
This fixes various issues with tracing-honeycomb. Refs: inanna-malick/tracing-honeycomb#15 Refs: inanna-malick/tracing-honeycomb#16 This also gets us other unreleased commits, allowing us to do per-trace sampling.
This was referenced Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honeycomb allows it's
trace_id's to be any arbitrary string. Respect that, because we may be sent an id from some source we do not directly control, such as an edge proxy.This changes
TraceIdto avoid parsing, and to internally just hold a string. Unfortunately the tracing crate imposes restrictions that make this untenable for span ids.This also includes a rework of sampling, making it be deterministic for a given
trace_id, and also allowing it to function on any string.Supersedes #9
@inanna-malick