-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add react-best-practices power #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add POWER.md with overview and quick reference - Add 45 individual rule files in steering/ - Add full-guide.md (compiled AGENTS.md) - Update README.md Source: https://github.com/vercel-labs/agent-skills/tree/main/skills/react-best-practices License: MIT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
This is an excellent addition to the Kiro powers repository! The React Best Practices power provides comprehensive, well-structured performance optimization guidelines from Vercel Engineering.
✅ Strengths:
- Comprehensive Coverage: 43 detailed rules across 8 categories with clear prioritization
- Excellent Structure: Well-organized with consistent frontmatter, clear examples, and practical code snippets
- High-Quality Content: Detailed explanations with "incorrect" vs "correct" examples for each rule
- Proper Attribution: Clear licensing and attribution to Vercel Engineering
- Consistent Formatting: All steering files follow a consistent structure with impact ratings and tags
🔧 Issues Found:
- Rule Count Inconsistency: The description claims "45 rules" but the actual count is 43 rules (verified by counting all steering files)
📋 Files Reviewed:
- Main power configuration and documentation
- Sample steering files for quality verification
- README integration
The content quality is exceptional and will be valuable for React/Next.js performance optimization. Once the rule count inconsistency is fixed, this power will be ready for merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| --- | ||
| name: "react-best-practices" | ||
| displayName: "React Best Practices" | ||
| description: "React and Next.js performance optimization guidelines from Vercel Engineering. 45 rules across 8 categories, prioritized by impact from CRITICAL to LOW." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛑 Inconsistency Error: The description claims "45 rules" but the table shows only 43 rules total (5+5+5+2+7+7+12+2=45, but the actual count in the steering files is 43). This discrepancy needs to be resolved for accuracy.
| description: "React and Next.js performance optimization guidelines from Vercel Engineering. 45 rules across 8 categories, prioritized by impact from CRITICAL to LOW." | |
| description: "React and Next.js performance optimization guidelines from Vercel Engineering. 43 rules across 8 categories, prioritized by impact from CRITICAL to LOW." |
|
|
||
| ## Overview | ||
|
|
||
| Comprehensive performance optimization guide for React and Next.js applications, maintained by Vercel Engineering. Contains 45 rules across 8 categories, prioritized by impact to guide code review, refactoring, and code generation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same inconsistency exists here - update to match the actual rule count.
| Comprehensive performance optimization guide for React and Next.js applications, maintained by Vercel Engineering. Contains 45 rules across 8 categories, prioritized by impact to guide code review, refactoring, and code generation. | |
| Comprehensive performance optimization guide for React and Next.js applications, maintained by Vercel Engineering. Contains 43 rules across 8 categories, prioritized by impact to guide code review, refactoring, and code generation. |
|
|
||
| Each rule is available as a separate steering file. Use `readSteering` with the rule name to get detailed explanations and code examples. | ||
|
|
||
| - **full-guide** - Complete compiled document with all 45 rules (2,200+ lines) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the full-guide description to reflect the correct rule count.
| - **full-guide** - Complete compiled document with all 45 rules (2,200+ lines) | |
| - **full-guide** - Complete compiled document with all 43 rules (2,200+ lines) |
| --- | ||
|
|
||
| ### react-best-practices | ||
| **React Best Practices** - React and Next.js performance optimization guidelines from Vercel Engineering. 45 rules across 8 categories, prioritized by impact from CRITICAL to LOW. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the README description to match the corrected rule count.
| **React Best Practices** - React and Next.js performance optimization guidelines from Vercel Engineering. 45 rules across 8 categories, prioritized by impact from CRITICAL to LOW. | |
| **React Best Practices** - React and Next.js performance optimization guidelines from Vercel Engineering. 43 rules across 8 categories, prioritized by impact from CRITICAL to LOW. |
Summary
Add React Best Practices power based on Vercel Engineering's performance optimization guidelines.
Contents
Categories (by priority)
Source
https://github.com/vercel-labs/agent-skills/tree/main/skills/react-best-practices
License
MIT (Original Author: @shuding at Vercel)