Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic taxonomy cutoff and re-normailzation #44

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Conversation

jtklein
Copy link
Contributor

@jtklein jtklein commented Dec 4, 2024

I have added a dynamic cutoff for taxonomy rollup. Using the top score (combined in iOS, vision only in Android becuase no geo model there yet) * 0.001. After aggregating the scores for all nodes the ones that are remaining are normalized again with the sum of all remaining leaf nodes.

@jtklein jtklein changed the title Common ancestor Dynamic taxonomy cutoff and re-normailzation Dec 4, 2024
@jtklein jtklein requested a review from alexshepard December 4, 2024 22:25
Setting a taxonomy cutoff from outside the native side overrides the now in built one of 0.001 * top score.
Copy link
Contributor

@alexshepard alexshepard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

ios/Classifier/VCPTaxonomy.m Show resolved Hide resolved
ios/Classifier/VCPTaxonomy.m Show resolved Hide resolved
@jtklein jtklein merged commit a8ca9de into main Dec 9, 2024
3 checks passed
@jtklein jtklein deleted the common-ancestor branch December 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants